Uh oh!
There was an error while loading. Please reload this page.
[v13.x backport] stream: simplify Writable.write - #32162
Conversation
ronag
commented
Mar 9, 2020
needs CI, Jenkins is however going down at the moment |
916e684 to
386ef63Compare386ef63 to
c935cd8CompareBackport-PR-URL: nodejs#32162
c935cd8 to
bf1bbe9Compareronag
commented
Mar 9, 2020
Note this actually backports two separate PR's. It was easier like this... |
nodejs-github-bot
commented
Mar 9, 2020
MylesBorins
commented
Mar 9, 2020
@ronag generally for backports we want to, as much as possible, keep the original commit meta data in place. In this case we have 3 commits that have now been merged into a single commit. Would it be a ton of extra work to retain that original structure? It makes it harder, at least for me, to review and compare the specific changes to see what the differences are... and almost requires full review now as it is a compeltely different patch then anything that we've landed |
@MylesBorins in this specific case it’s a bit harder. Since a commit both of these depend on seems to be missing. I can try again... |
PR-URL: #31146, #31624
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes