Skip to content

[v13.x backport] stream: simplify Writable.write - #32162

Closed
ronag wants to merge 1 commit into
nodejs:v13.x-stagingfrom
nxtedition:backport-31146-to-v13.x
Closed

[v13.x backport] stream: simplify Writable.write#32162
ronag wants to merge 1 commit into
nodejs:v13.x-stagingfrom
nxtedition:backport-31146-to-v13.x

Conversation

@ronag

@ronagronag commented Mar 9, 2020

Copy link
Copy Markdown
Member

PR-URL: #31146, #31624

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronagronag added the stream Issues and PRs related to the stream subsystem. label Mar 9, 2020
@ronag
ronag requested a review from MylesBorinsMarch 9, 2020 22:16
@ronag

ronag commented Mar 9, 2020

Copy link
Copy Markdown
MemberAuthor

needs CI, Jenkins is however going down at the moment

@ronag
ronagforce-pushed the backport-31146-to-v13.x branch from 916e684 to 386ef63CompareMarch 9, 2020 22:24
@ronag
ronagforce-pushed the backport-31146-to-v13.x branch from 386ef63 to c935cd8CompareMarch 9, 2020 22:25
@ronag
ronagforce-pushed the backport-31146-to-v13.x branch from c935cd8 to bf1bbe9CompareMarch 9, 2020 22:51
@ronag

ronag commented Mar 9, 2020

Copy link
Copy Markdown
MemberAuthor

Note this actually backports two separate PR's. It was easier like this...

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@MylesBorins

Copy link
Copy Markdown
Contributor

@ronag generally for backports we want to, as much as possible, keep the original commit meta data in place. In this case we have 3 commits that have now been merged into a single commit. Would it be a ton of extra work to retain that original structure? It makes it harder, at least for me, to review and compare the specific changes to see what the differences are... and almost requires full review now as it is a compeltely different patch then anything that we've landed

@ronag

ronag commented Mar 10, 2020

Copy link
Copy Markdown
MemberAuthor

@MylesBorins in this specific case it’s a bit harder. Since a commit both of these depend on seems to be missing. I can try again...

@ronagronag closed this Mar 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ronag@nodejs-github-bot@MylesBorins