Uh oh!
There was an error while loading. Please reload this page.
doc: expand fs.watch caveats - #32176
Closed
bzoz wants to merge 2 commits into
Closed
Conversation
Document Windows specific fs.watch caveats. Fixes: nodejs#31702
bnoordhuis
approved these changes
Mar 10, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott
reviewed
Mar 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
bzoz
commented
Mar 11, 2020
ContributorAuthor
Updated, PTAL |
bnoordhuis
approved these changes
Mar 11, 2020
shisama
approved these changes
Mar 11, 2020
cjihrig
approved these changes
Mar 11, 2020
lpinca
approved these changes
Mar 12, 2020
jasnell
approved these changes
Mar 12, 2020
addaleax
commented
Mar 13, 2020
Member
Landed in 1a844a6 |
addaleax pushed a commit
that referenced
this pull request
Mar 13, 2020
Document Windows specific fs.watch caveats. Fixes: #31702 PR-URL: #32176 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Mar 17, 2020
Document Windows specific fs.watch caveats. Fixes: #31702 PR-URL: #32176 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 24, 2020
Document Windows specific fs.watch caveats. Fixes: #31702 PR-URL: #32176 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 22, 2020
Document Windows specific fs.watch caveats. Fixes: #31702 PR-URL: #32176 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document Windows specific fs.watch caveats.
Fixes: #31702
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes