Uh oh!
There was an error while loading. Please reload this page.
stream: avoid destroying writable source - #32198
Closed
ronag wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Mar 11, 2020
Collaborator
MylesBorins
commented
Mar 11, 2020
Contributor
can we fast track this? I'd like to see it land in the upcoming 13.11.0 release @ronag looks like this needs a rebase |
ronagforce-pushed
the
stream-pipeline-destroy
branch
from
March 11, 2020 15:54
0506fd0 to
7b3ecccCompareMemberAuthor
rebased @MylesBorins |
nodejs-github-bot
commented
Mar 11, 2020
Collaborator
jasnell
reviewed
Mar 11, 2020
Member
There was a problem hiding this comment.
A test that has a Duplex piping back in to itself would be good also
MemberAuthor
There was a problem hiding this comment.
I suppose this is a nit? Since we might want to fast-track this would you mind if I do so in a follow up PR later?
jasnell
approved these changes
Mar 11, 2020
MylesBorins
commented
Mar 11, 2020
Contributor
@ronag fwiw you can't approve fastrack on your own PR |
ronag
commented
Mar 11, 2020
MemberAuthor
Np, I was +1 the rebase part of your comment. I'll remove my +1. |
jasnell
commented
Mar 11, 2020
Member
+1 to fast tracking |
nodejs-github-bot
commented
Mar 11, 2020
Collaborator
MylesBorins
commented
Mar 11, 2020
Contributor
@ronag FWIW this patch is not going to land cleanly on v13.x. You might want to get started on a backport now if you have time. very much trying to get this out in today's release. |
4 tasks
2 tasks
nodejs-github-bot
commented
Mar 11, 2020
Collaborator
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Fixes: nodejs@4d93e10#commitcomment-37751035
ronag
commented
Mar 11, 2020
MemberAuthor
Fixed conflicts |
ronagforce-pushed
the
stream-pipeline-destroy
branch
from
March 11, 2020 19:34
7b3eccc to
5daaddbCompareCollaborator
nodejs-github-bot
commented
Mar 12, 2020
Collaborator
MylesBorins pushed a commit
that referenced
this pull request
Mar 12, 2020
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. PR-URL: #32198 Refs: 4d93e10#commitcomment-37751035 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
commented
Mar 12, 2020
Contributor
landed in 2bfb340 |
MylesBorins pushed a commit
that referenced
this pull request
Mar 12, 2020
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Backport-PR-URL: #32212 PR-URL: #32198 Refs: 4d93e10#commitcomment-37751035 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.
Fixes: 4d93e10#commitcomment-37751035
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes