Skip to content

deps,doc: move openssl maintenance guide to doc - #32209

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:maintaining-openssl
Closed

deps,doc: move openssl maintenance guide to doc#32209
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:maintaining-openssl

Conversation

@sam-github

@sam-githubsam-github commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 11, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.
@jasnell

Copy link
Copy Markdown
Member

Can we fasttrack this?

@sam-githubsam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 13, 2020
@sam-github

Copy link
Copy Markdown
ContributorAuthor

I'm OK with it, not sure how many +1s we need.

jasnell pushed a commit that referenced this pull request Mar 17, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.
PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in 5eb85dd

@jasnelljasnell closed this Mar 17, 2020
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.
PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 19, 2020
@sam-github
sam-github deleted the maintaining-openssl branch March 20, 2020 21:34
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.
PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.
PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Apr 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.opensslIssues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sam-github@jasnell@cjihrig@richardlau@nodejs-github-bot