Skip to content

doc: add Ruben to TSC - #32213

Closed
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:addRuben2
Closed

doc: add Ruben to TSC#32213
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:addRuben2

Conversation

@mhdawson

@mhdawsonmhdawson commented Mar 11, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mhdawson
doc: add Ruben to TSC
c2ddb86
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 11, 2020
@mhdawson

mhdawson commented Mar 11, 2020

Copy link
Copy Markdown
MemberAuthor

@BridgeAR Welcome!

@mhdawsonmhdawson mentioned this pull request Mar 11, 2020
Closed
@mhdawson

mhdawson commented Mar 11, 2020

Copy link
Copy Markdown
MemberAuthor

Fast Track ?

@mhdawsonmhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2020
@mhdawsonmhdawson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2020
@mhdawson

mhdawson commented Mar 11, 2020

Copy link
Copy Markdown
MemberAuthor

Once CI is complete I think this can land based on the fast track process.

@ChALkeR
ChALkeR requested a review from BridgeARMarch 11, 2020 22:28
@BridgeAR

BridgeAR commented Mar 11, 2020

Copy link
Copy Markdown
Member

Thanks, you all!

gireeshpunathil
gireeshpunathil reviewed Mar 12, 2020
View reviewed changes
Comment threadREADME.md Outdated
Trott pushed a commit that referenced this pull request Mar 12, 2020
@mhdawson@Trott
doc: add Ruben to TSC
e458747
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Mar 12, 2020

Copy link
Copy Markdown
Member

Landed in e458747

@TrottTrott closed this Mar 12, 2020
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
@mhdawson@BridgeAR
doc: add Ruben to TSC
c5a3bfd
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@mhdawson@MylesBorins
doc: add Ruben to TSC
19fee76
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@mhdawson@targos
doc: add Ruben to TSC
c1c3aa1
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Apr 22, 2020
Merged
@mhdawson
mhdawson deleted the addRuben2 branch September 14, 2020 21:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@ZYSzysZYSzysZYSzys approved these changes
@BridgeARBridgeARAwaiting requested review from BridgeAR
+1 more reviewer
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@mhdawson@BridgeAR@Trott@ChALkeR@jasnell@lpinca@tniessen@mmarchini@richardlau@gireeshpunathil@ZYSzys@nodejs-github-bot