Uh oh!
There was an error while loading. Please reload this page.
stream: change var to let/const in lib stream js files. - #32214
Closed
Saajan wants to merge 1 commit into
Closed
Conversation
ronag
approved these changes
Mar 11, 2020
nodejs-github-bot
commented
Mar 11, 2020
Collaborator
trivikr
commented
Mar 18, 2020
Member
@Saajan This needs rebase as _stream_writable.js was updated in #32037 Can you please update PR title to git commit message guidelines? |
Saajan
commented
Mar 18, 2020
ContributorAuthor
Thank you for the suggestions. I have done the changes you asked. |
trivikr
approved these changes
Mar 18, 2020
jasnell
approved these changes
Mar 18, 2020
ronag
approved these changes
Mar 20, 2020
addaleax
approved these changes
Mar 29, 2020
nodejs-github-bot
commented
Mar 29, 2020
Collaborator
nodejs-github-bot
commented
Mar 30, 2020
Collaborator
addaleax
commented
Mar 30, 2020
Member
Landed in 4fc13b0 🎉 |
addaleax pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32214 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32214 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes