Skip to content

zlib: destroy only when both readable and writable finished - #32216

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:zlib-auto-destroy
Closed

zlib: destroy only when both readable and writable finished#32216
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:zlib-auto-destroy

Conversation

@ronag

@ronagronag commented Mar 11, 2020

Copy link
Copy Markdown
Member

Related to #32215

A zlib stream should not be destroyed until both sides has completed. Since 'end' can be emitted before 'finish'.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronagronag added stream Issues and PRs related to the stream subsystem. zlib Issues and PRs related to the zlib subsystem. labels Mar 11, 2020
@ronag
ronag requested a review from addaleaxMarch 11, 2020 22:20
@ronagronag mentioned this pull request Mar 11, 2020
Closed
@ronag
ronagforce-pushed the zlib-auto-destroy branch from 6cf1ace to 1a769bcCompareMarch 11, 2020 22:29
@ronag

ronag commented Mar 12, 2020

Copy link
Copy Markdown
MemberAuthor

Close in favor of #32220

@ronagronag closed this Mar 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ronag