Skip to content

docs: end(cb) cb can be invoked with error - #32238

Closed
rexagod wants to merge 7 commits into
nodejs:masterfrom
rexagod:writable-end-docs
Closed

docs: end(cb) cb can be invoked with error#32238
rexagod wants to merge 7 commits into
nodejs:masterfrom
rexagod:writable-end-docs

Conversation

@rexagod

@rexagodrexagod commented Mar 12, 2020•
edited
Loading

Copy link
Copy Markdown
Member

update docs that the optional callback passed to
writable.end can be invoked in case of an error as well

fixes: #31220

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@rexagod
docs: end(cb) cb can be invoked with error
35f4e6c
update docs that the optional callback passed to
`writable.end` can be invoked in case of an error as well
fixes: nodejs#31220
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Mar 12, 2020
mscdex
mscdex reviewed Mar 12, 2020
View reviewed changes
Comment threaddoc/api/stream.md Outdated
lpinca
lpinca approved these changes Mar 13, 2020
View reviewed changes

@lpincalpinca left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add an entry in the changes: array of the YAML metadata.

@rexagod

rexagod commented Mar 14, 2020

Copy link
Copy Markdown
MemberAuthor

@lpinca Sorry, I don't know what you meant by that. Could you explain that a bit? Thanks!

ronag
ronag reviewed Mar 14, 2020
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@lpinca

lpinca commented Mar 15, 2020

Copy link
Copy Markdown
Member

@rexagod see line 408-410. I mean an entry like that.

addaleax
addaleax reviewed Mar 29, 2020
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@rexagod
rexagod requested a review from addaleaxMarch 29, 2020 20:12
addaleax
addaleax reviewed Mar 29, 2020
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@rexagod@addaleax
Update doc/api/stream.md
78a6211
Co-Authored-By: Anna Henningsen <github@addaleax.net>
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@rexagod@addaleax
doc: stream.end(cb) cb can be invoked with error
6ade42b
Update docs that the optional callback passed to
`writable.end` can be invoked in case of an error as well.
PR-URL: #32238Fixes: #31220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax

addaleax commented Mar 30, 2020

Copy link
Copy Markdown
Member

Landed in 6ade42b

@BethGriggsBethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronagronagronag left review comments
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
+1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: end(cb) cb can be invoked with error

6 participants

@rexagod@lpinca@addaleax@mscdex@ronag@nodejs-github-bot