Skip to content

test: use Promise.all() in test-hash-seed - #32273

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:pummel-hash-seed
Closed

test: use Promise.all() in test-hash-seed#32273
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:pummel-hash-seed

Conversation

@Trott

@TrottTrott commented Mar 14, 2020

Copy link
Copy Markdown
Member

We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 14, 2020
@Trott

Trott commented Mar 15, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12864/ ✅

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2020
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment threadtest/pummel/test-hash-seed.js Outdated
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment threadtest/pummel/test-hash-seed.js Outdated
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment threadtest/pummel/test-hash-seed.js Outdated
jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
Comment threadtest/pummel/test-hash-seed.js Outdated
@Trott

Trott commented Mar 17, 2020

Copy link
Copy Markdown
MemberAuthor

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12912/

antsmartian
antsmartian approved these changes Mar 17, 2020
View reviewed changes

@antsmartianantsmartian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Mar 18, 2020
@Trott
test: use Promise.all() in test-hash-seed
1a3c747
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.
PR-URL: nodejs#32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@Trott

Trott commented Mar 18, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 1a3c747

@TrottTrott closed this Mar 18, 2020
@Trott
Trott deleted the pummel-hash-seed branch March 18, 2020 01:30
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
@Trott@MylesBorins
test: use Promise.all() in test-hash-seed
7d1e170
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.
PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott@MylesBorins
test: use Promise.all() in test-hash-seed
05fd160
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.
PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott@targos
test: use Promise.all() in test-hash-seed
8dbd7cf
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.
PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@targostargos mentioned this pull request Apr 22, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@jasnelljasnelljasnell approved these changes
@tniessentniessentniessen approved these changes
+1 more reviewer
@antsmartianantsmartianantsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@jasnell@antsmartian@targos@tniessen@nodejs-github-bot