Uh oh!
There was an error while loading. Please reload this page.
stream: don't emit 'finish' after 'error' - #32275
Closed
ronag wants to merge 2 commits into
Closed
Conversation
ronagforce-pushed
the
stream-error-finish
branch
2 times, most recently
from
March 14, 2020 23:59
7999e19 to
96e82caComparenodejs-github-bot
commented
Mar 15, 2020
Collaborator
lpinca
approved these changes
Mar 15, 2020
nodejs-github-bot
commented
Mar 15, 2020
Collaborator
jasnell
reviewed
Mar 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
jasnell
approved these changes
Mar 16, 2020
Co-Authored-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
commented
Mar 16, 2020
Collaborator
ronag
commented
Mar 17, 2020
MemberAuthor
Landed in 9b20b5d |
MylesBorins
commented
Mar 19, 2020
Contributor
@ronag this doesn't land cleanly on v13.x, should it be backported? |
4 tasks
ronag added a commit
to nxtedition/node
that referenced
this pull request
Mar 19, 2020
PR-URL: nodejs#32275 Refs: nodejs#28710 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#32372
MylesBorins pushed a commit
that referenced
this pull request
Mar 24, 2020
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An edge case could emit
'finish'after'error'.Refs: #28710
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes