Skip to content

build: add --with-arm-fpu option - #3228

Closed
kapouer wants to merge 2 commits into
nodejs:masterfrom
kapouer:patch-2
Closed

build: add --with-arm-fpu option#3228
kapouer wants to merge 2 commits into
nodejs:masterfrom
kapouer:patch-2

Conversation

@kapouer

@kapouerkapouer commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

@brendanashworthbrendanashworth added build Issues and PRs related to build files or the CI. arm Issues and PRs related to the ARM architecture. labels Oct 7, 2015
mscdex
mscdex reviewed Oct 7, 2015
View reviewed changes
Comment threadconfigure Outdated

@mscdexmscdexOct 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really make sense to make this explicit setting overridable by the configure script? It seems like if someone is passing the option explicitly, it should not be overridden. For example, what if an armv7 user would want to use vfp or vfpv2 instead of vfpv3 (e.g. for debugging or other reasons)?

@kapouer

kapouer commented Oct 7, 2015

Copy link
Copy Markdown
ContributorAuthor

I removed the default value of the option, set it inside the method which decides sane defaults,
but which honor the option in case it is set.

bnoordhuis
bnoordhuis reviewed Oct 7, 2015
View reviewed changes
Comment threadconfigure Outdated

@bnoordhuisbnoordhuisOct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V8 also knows about vfpv3-d16. I don't know how common it is but might be nice to add.

@bnoordhuis

bnoordhuis commented Oct 7, 2015

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/440/

@bnoordhuis

bnoordhuis commented Oct 7, 2015

Copy link
Copy Markdown
Member

LGTM, I'll squash it when I land it. @mscdex LGTY?

@mscdex

mscdex commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

LGTM I guess the test-stringbytes-external failure on node-test-binary-arm is not related...

bnoordhuis pushed a commit that referenced this pull request Oct 7, 2015
@kapouer@bnoordhuis
build: add --with-arm-fpu option
17665af
Fixes: #2942
PR-URL: #3228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
@bnoordhuis

bnoordhuis commented Oct 7, 2015

Copy link
Copy Markdown
Member

Landed in 17665af, thanks.

@mscdex test-stringbytes-external is failure prone on underpowered machines, it allocates a lot of memory.

@jasnelljasnell mentioned this pull request Oct 8, 2015
Closed
29 tasks
jasnell pushed a commit that referenced this pull request Oct 8, 2015
@kapouer@jasnell
build: add --with-arm-fpu option
b3c5ad1
Fixes: #2942
PR-URL: #3228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnelljasnell mentioned this pull request Oct 8, 2015
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

armIssues and PRs related to the ARM architecture.buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kapouer@bnoordhuis@mscdex@jasnell@brendanashworth