Skip to content

[v12.x backport] module: drop support for extensionless main entry points in esm - #32280

Closed
GeoffreyBooth wants to merge 1 commit into
nodejs:v12.x-stagingfrom
GeoffreyBooth:backport-31415-to-12.x-staging
Closed

[v12.x backport] module: drop support for extensionless main entry points in esm#32280
GeoffreyBooth wants to merge 1 commit into
nodejs:v12.x-stagingfrom
GeoffreyBooth:backport-31415-to-12.x-staging

Conversation

@GeoffreyBooth

@GeoffreyBoothGeoffreyBooth commented Mar 15, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Backport of #31415. Thank you @codebytere for the prompt!

This isn't as clean as it could be because of 04d07ed. @bmeck or @guybedford do you mind double-checking this? I'm assuming that we don't want to merge into 12 the commit that was reverted.

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. v12.x labels Mar 15, 2020
@GeoffreyBooth
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 4d3b533 to 8e8b655CompareMarch 15, 2020 05:37
@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29844/

@GeoffreyBooth

This comment has been minimized.

Sign in to view
@GeoffreyBooth
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 8e8b655 to e1a4de2CompareMarch 15, 2020 06:12
@GeoffreyBooth
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from e1a4de2 to 287ef5fCompareMarch 15, 2020 06:18
@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29845/

@puzpuzpuzpuzpuzpuz mentioned this pull request Mar 15, 2020
Closed
4 tasks
@puzpuzpuz

puzpuzpuz commented Mar 15, 2020

Copy link
Copy Markdown
Member

This PR doesn't edit repl.md. Is v12.x-staging in a broken state?

I've created #32282 to deal with that.

@GeoffreyBooth
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 287ef5f to 4ee0478CompareMarch 16, 2020 03:15
@codebytere

This comment has been minimized.

Sign in to view
@GeoffreyBooth
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 4ee0478 to 3f31b1aCompareMarch 17, 2020 03:58
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29880/

@GeoffreyBooth
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 3f31b1a to bb4fbbeCompareMarch 18, 2020 03:16
@GeoffreyBooth

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 19, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29927/

@codebytere

This comment has been minimized.

Sign in to view
@guybedford
guybedfordforce-pushed the backport-31415-to-12.x-staging branch from bb4fbbe to 3e13dc7CompareMarch 23, 2020 01:34
@nodejs-github-bot

nodejs-github-bot commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29989/

@GeoffreyBooth
GeoffreyBoothforce-pushed the backport-31415-to-12.x-staging branch from 009d0a2 to 0da01a7CompareMarch 24, 2020 22:23
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30039/

@GeoffreyBooth

GeoffreyBooth commented Mar 24, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@codebytere I've been struggling with this for over a week now and I just can't get CI to pass.

From what I can tell of the CI jobs that are failing, like node-test-commit-aix, it appears that make test-ci and/or make run-ci are failing:

18:11:37 gmake[1]: *** [Makefile:529: test-ci] Error 1
18:11:37 gmake: *** [Makefile:557: run-ci] Error 2

When I run locally, I get this error with make run-ci:

not ok 636 parallel/test-fs-stat-bigint
---
duration_ms: 0.248
severity: fail
exitcode: 1
stack: |-
assert.js:385
throw err;
^
AssertionError [ERR_ASSERTION]: Number version atimeMs = 1585172518639.4456, BigInt version atimeMs = 1585172518625n, Allowable delta = 14
at verifyStats (/Users/geoffrey/Sites/node/test/parallel/test-fs-stat-bigint.js:71:7)

Perhaps we need to increase the allowable delta here?

@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30070/

@GeoffreyBoothGeoffreyBooth mentioned this pull request Mar 25, 2020
Closed
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30079/

@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30097/

@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30101/

@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30102/

@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30103/

@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30105/

@GeoffreyBooth

GeoffreyBooth commented Mar 26, 2020

Copy link
Copy Markdown
MemberAuthor

@codebytere I keep resuming CI, but node-test-commit-aix keeps failing. It fails for v12.x-staging too: https://ci.nodejs.org/job/node-test-commit/36866/.

Can we land this, since the problem appears to be in the staging branch?

@MylesBorins

MylesBorins commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

As the failure seems unrelated to this PR and on the staging branch I think this is ok to land

@codebytere thoughts?

MylesBorins
MylesBorins approved these changes Mar 26, 2020
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30107/

@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30108/

@codebytere
codebytereforce-pushed the v12.x-staging branch 2 times, most recently from 63a03d2 to d577190CompareMarch 31, 2020 23:57
@codebytere

codebytere commented Apr 1, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@GeoffreyBooth staging should be good to rebase against, then we can get this landed.

@GeoffreyBooth@guybedford
module: drop support for extensionless main entry points in esm
b6ad757
PR-URL: nodejs#31415
Backport-PR-URL: nodejs#32280
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@guybedford
guybedfordforce-pushed the backport-31415-to-12.x-staging branch from 0da01a7 to b6ad757CompareApril 1, 2020 02:36
@guybedford

guybedford commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

I've updated the rebase here.

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30309/

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30310/

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020•
edited by MylesBorins
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30314/
rerun linuxone: https://ci.nodejs.org/job/node-test-commit-linuxone/19987/

MylesBorins pushed a commit that referenced this pull request Apr 1, 2020
@GeoffreyBooth@MylesBorins
module: drop support for extensionless main entry points in esm
4ee41c5
Backport-PR-URL: #32280
PR-URL: #31415
Backport-PR-URL: #32280
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins

MylesBorins commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

finally green!

Landed in 4ee41c5

@GeoffreyBooth
GeoffreyBooth deleted the backport-31415-to-12.x-staging branch April 1, 2020 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@awiboxawiboxawibox left review comments
@bmeckbmeckbmeck approved these changes
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@GeoffreyBooth@nodejs-github-bot@puzpuzpuz@codebytere@MylesBorins@guybedford@bmeck@awibox