Skip to content

src: replace handle dereference with ContainerOf macro - #32298

Closed
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:handle_dereference_process_wrap
Closed

src: replace handle dereference with ContainerOf macro#32298
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:handle_dereference_process_wrap

Conversation

@HarshithaKP

@HarshithaKPHarshithaKP commented Mar 16, 2020

Copy link
Copy Markdown
Member

this was influenced by #32269

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. labels Mar 16, 2020
addaleax
addaleax approved these changes Mar 16, 2020
View reviewed changes
Comment threadsrc/process_wrap.cc Outdated
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29864/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30198/

addaleax pushed a commit that referenced this pull request Mar 29, 2020
@HarshithaKP@addaleax
src: replace handle dereference with ContainerOf
768b0f5
this was influenced by #32269
PR-URL: #32298
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

addaleax commented Mar 29, 2020

Copy link
Copy Markdown
Member

Landed in 768b0f5

addaleax pushed a commit that referenced this pull request Mar 30, 2020
@HarshithaKP@addaleax
src: replace handle dereference with ContainerOf
06bff18
this was influenced by #32269
PR-URL: #32298
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@HarshithaKP@targos
src: replace handle dereference with ContainerOf
4155358
this was influenced by #32269
PR-URL: #32298
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Apr 22, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.child_processIssues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HarshithaKP@nodejs-github-bot@addaleax@jasnell@cjihrig