test: linting for buffer-free-callback test

[Trott]

Test added in d1f2404 does not pass linting rule added in 3de353b.
Fixed in this commit. common module required in all tests except
those that intentionally leak variables.

Fixes: #3229

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/437/

[Trott]

/cc @indutny This minor change to your test look good to you?

[Fishrock123]

LGTM

[indutny]

@Trott I didn't see any errors when committing it. Are you sure that it is required for addons?

[Trott]

@indutny Yes, I'm postive.

$ git checkout d1f2404 Note: checking out 'd1f2404'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b new_branch_name
HEAD is now at d1f2404... buffer: FreeCallback should be tied to ArrayBuffer
$ make jslint
./node tools/eslint/bin/eslint.js src lib test tools/eslint-rules \
--rulesdir tools/eslint-rules --reset --quiet
test/addons/buffer-free-callback/test.js
1:0 error Mandatory module "common" must be loaded required-modules
✖ 1 problem (1 error, 0 warnings)
make: *** [jslint] Error 1
$

[indutny]

Ok, LGTM then.

[indutny]

Shouldn't it go to other addons too?

[Trott]

Yes, all the previously existing addon tests that didn't use common got it in c78091d which is the commit immediately prior to the linting rule.

[Trott]

Because this change is so small and CI will fail until it lands, I'm going to go ahead and land it right away.

[Trott]

Landed in 6f63a4a