Skip to content

deps: update acorn to v7.1.1 - #32310

Closed
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:2020-03-17-update-acorn-deps
Closed

deps: update acorn to v7.1.1#32310
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:2020-03-17-update-acorn-deps

Conversation

@BridgeAR

@BridgeARBridgeAR commented Mar 17, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
BridgeARforce-pushed the 2020-03-17-update-acorn-deps branch from c745361 to 911a5aeCompareMarch 17, 2020 01:51
Also clean up the plugins package.json files.
@BridgeAR
BridgeARforce-pushed the 2020-03-17-update-acorn-deps branch from 911a5ae to 6c17b42CompareMarch 17, 2020 02:10

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2020

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

nodejs-github-bot commented Mar 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30138/ (:heavy_check_mark:)

@addaleax

Copy link
Copy Markdown
Member

Landed in 08c656b

addaleax pushed a commit that referenced this pull request Mar 29, 2020
Also clean up the plugins package.json files.
PR-URL: #32310
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
Also clean up the plugins package.json files.
PR-URL: #32310
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Apr 13, 2020
targos pushed a commit that referenced this pull request Apr 22, 2020
Also clean up the plugins package.json files.
PR-URL: #32310
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Apr 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@BridgeAR@nodejs-github-bot@addaleax@jasnell@Trott@gengjiawen@trivikr