Uh oh!
There was an error while loading. Please reload this page.
Revert "deps: backport 03ef3cd from V8 upstream" - #3237
Conversation
targos
commented
Oct 7, 2015
LGTM. The Chromium bug report is not accessible? |
ofrobots
commented
Oct 7, 2015
Basically it has been causing crash reports on chrome canary. Access is probably restricted because of the existence of the crash report data. Here's the relevant comment:
|
This reverts commit 6fff47f as it is causing issues in upstream: https://codereview.chromium.org/1390923004/ PR-URL: nodejs#3237 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
This reverts commit 6fff47f as it is causing issues in upstream: https://codereview.chromium.org/1390923004/ PR-URL: #3237 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
ofrobots
commented
Oct 7, 2015
CI (just in case): https://ci.nodejs.org/job/node-test-pull-request/442/ |
bnoordhuis
commented
Oct 7, 2015
LGTM |
targos
commented
Oct 7, 2015
landed in a334ddc |
This reverts commit 6fff47f as it is causing
issues in upstream: https://codereview.chromium.org/1390923004/
Original PR: #3165.
R=@bnoordhuis, @targos