Uh oh!
There was an error while loading. Please reload this page.
[v13.x backport] zlib: align with streams - #32371
Closed
ronag wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Mar 19, 2020
Collaborator
- Ensure automatic destruction only happens after both 'end' and 'finish' has been emitted through autoDestroy. - Ensure close() callback is always invoked. - Ensure 'error' is only emitted once. PR-URL: nodejs#32220 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Backport-PR-URL: nodejs#32371
ronagforce-pushed
the
backport-32220-to-v13.x
branch
from
March 19, 2020 21:15
dc563f1 to
76fd0e5CompareMylesBorins
commented
Mar 19, 2020
Contributor
MylesBorins
commented
Mar 19, 2020
Contributor
also there are a ton of failures PTAL |
ronag
commented
Mar 19, 2020
MemberAuthor
MemberAuthor
I think most of the failures is due to the fact we don't emit |
nodejs-github-bot
commented
Mar 19, 2020
Collaborator
ronag
commented
Mar 19, 2020
| ts.on('close', common.mustCall(() => { | ||
| ts.close(common.mustCall()); | ||
| })); | ||
| ts.on('close', common.mustCall()); |
MemberAuthor
There was a problem hiding this comment.
finished does not invoke callback on closed stream, this was a semver-major fix does not land on 13
ronag
commented
Mar 19, 2020
| name: 'Error', | ||
| message: 'Cannot call write after a stream was destroyed' | ||
| } | ||
| ); |
MemberAuthor
There was a problem hiding this comment.
I'm a little unsure how exactly this could throw before.
ronag
commented
Mar 19, 2020
| assert.throws( | ||
| () => gunzip.write({}), | ||
| TypeError | ||
| ); |
MemberAuthor
There was a problem hiding this comment.
I'm a little unsure how exactly this could throw before.
ronag
commented
Mar 23, 2020
MemberAuthor
PR was just labeled as semver-major so I guess this should not be backported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #32220
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes