Skip to content

[v12.x] Backport n api 6 to v12.x - #32482

Closed
gabrielschulhof wants to merge 3 commits into
nodejs:v12.x-stagingfrom
gabrielschulhof:backport-n-api-6-to-v12.x
Closed

[v12.x] Backport n api 6 to v12.x#32482
gabrielschulhof wants to merge 3 commits into
nodejs:v12.x-stagingfrom
gabrielschulhof:backport-n-api-6-to-v12.x

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Mar 25, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v12.x labels Mar 25, 2020
@gabrielschulhofgabrielschulhof added i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. node-api Issues and PRs related to the Node-API. and removed i18n-api Issues and PRs related to the i18n implementation. labels Mar 25, 2020
@gabrielschulhofgabrielschulhof changed the title Backport n api 6 to v12.x[v12.x] Backport n api 6 to v12.xMar 25, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30063/

@mhdawson

mhdawson commented Mar 25, 2020

Copy link
Copy Markdown
Member

@gabrielschulhof did the commits apply cleanly?

@gabrielschulhof

gabrielschulhof commented Mar 25, 2020

Copy link
Copy Markdown
ContributorAuthor

@mhdawson only the commit defining N-API 6 did not apply cleanly.

@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30076/

mhdawson
mhdawson approved these changes Mar 26, 2020
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30250/

@codebytere
codebytereforce-pushed the v12.x-staging branch 2 times, most recently from 63a03d2 to d577190CompareMarch 31, 2020 23:57
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30383/

Gabriel Schulhofand others added 3 commits April 2, 2020 12:27
Gabriel Schulhof
test: cover property n-api null cases
3cb02e5
Add test coverage for passing `NULL` to each parameter of
`napi.*(propert|element)` and `napi_set_prototype`. In the case of
`napi_define_properties` also test setting various initializer fields
to `NULL`.
PR-URL: nodejs#31488
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@himself65Gabriel Schulhof
n-api: add napi_get_all_property_names
96cb864
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: nodejs#30006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Gabriel Schulhof@legendecas
n-api: define release 6
3a3c011
Mark all N-APIs that have been added since version 5 as stable.
PR-URL: nodejs#32058Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <legendecas@gmail.com>
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
gabrielschulhofforce-pushed the backport-n-api-6-to-v12.x branch from 189b47f to 3a3c011CompareApril 2, 2020 19:28
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30388/

@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30412/

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30530/

@goto-bus-stopgoto-bus-stop mentioned this pull request Apr 10, 2020
Merged
@gabrielschulhofgabrielschulhof mentioned this pull request Apr 21, 2020
Closed
3 tasks
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@himself65@targos
n-api: add napi_get_all_property_names
fb4fc96
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Backport-PR-URL: nodejs#32482
PR-URL: nodejs#30006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Gabriel Schulhof@targos
test: cover property n-api null cases
364fcaf
Add test coverage for passing `NULL` to each parameter of
`napi.*(propert|element)` and `napi_set_prototype`. In the case of
`napi_define_properties` also test setting various initializer fields
to `NULL`.
Backport-PR-URL: nodejs#32482
PR-URL: nodejs#31488
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Gabriel Schulhof@legendecas@targos
n-api: define release 6
12b3fca
Mark all N-APIs that have been added since version 5 as stable.
Backport-PR-URL: nodejs#32482
PR-URL: nodejs#32058Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <legendecas@gmail.com>
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos

targos commented Apr 25, 2020

Copy link
Copy Markdown
Member

Thanks. Landed on my WIP branch for v12.17.0: https://github.com/targos/node/commits/prepare-minor

@targostargos closed this Apr 25, 2020
targos pushed a commit that referenced this pull request Apr 28, 2020
@himself65@targos
n-api: add napi_get_all_property_names
f56c4dd
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Backport-PR-URL: #32482
PR-URL: #30006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
Gabriel Schulhof@targos
test: cover property n-api null cases
02ec03c
Add test coverage for passing `NULL` to each parameter of
`napi.*(propert|element)` and `napi_set_prototype`. In the case of
`napi_define_properties` also test setting various initializer fields
to `NULL`.
Backport-PR-URL: #32482
PR-URL: #31488
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
Gabriel Schulhof@legendecas@targos
n-api: define release 6
e22d853
Mark all N-APIs that have been added since version 5 as stable.
Backport-PR-URL: #32482
PR-URL: #32058Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <legendecas@gmail.com>
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
gabrielschulhof deleted the backport-n-api-6-to-v12.x branch January 28, 2021 00:14
@gabrielschulhof
gabrielschulhof restored the backport-n-api-6-to-v12.x branch January 28, 2021 05:40
@gabrielschulhof
gabrielschulhof deleted the backport-n-api-6-to-v12.x branch February 3, 2021 07:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes
@MylesBorinsMylesBorinsAwaiting requested review from MylesBorins
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.node-apiIssues and PRs related to the Node-API.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielschulhof@nodejs-github-bot@mhdawson@targos@legendecas@himself65