Skip to content

doc: typo Experimenetal to Experimental - #3260

Closed
reggi wants to merge 1 commit into
nodejs:masterfrom
reggi:patch-1
Closed

doc: typo Experimenetal to Experimental#3260
reggi wants to merge 1 commit into
nodejs:masterfrom
reggi:patch-1

Conversation

@reggi

@reggireggi commented Oct 8, 2015

Copy link
Copy Markdown
Contributor

No description provided.

Comment threadCHANGELOG.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's unintended?

@reggi

reggi commented Oct 8, 2015

Copy link
Copy Markdown
ContributorAuthor

@targos Sorry about that, thanks for the catch!

@reggi

reggi commented Oct 8, 2015

Copy link
Copy Markdown
ContributorAuthor

Ugh Atom removed a trailing space too.

@ChALkeRChALkeR added the doc Issues and PRs related to the documentations. label Oct 8, 2015
@ChALkeR

Copy link
Copy Markdown
Member

I see a lot of commits here: https://github.com/nodejs/node/pulls?q=is%3Aopen+is%3Apr+author%3Areggi+label%3Adoc+typo (namely 11).
Those would create a lot of commit noise. Why not unify them under one pull request and then squash to a single commit?
/cc @Fishrock123

@silverwind

Copy link
Copy Markdown
Contributor

Yes, merge them into one pull request please. Commiters can squash on merge, so it's not of concern if you have multiple commits in a single PR. I think we should add to CONTRIBUTING.md that we prefer single PRs for related changes.

@ChALkeR

Copy link
Copy Markdown
Member

Replaced by #3291.

@ChALkeRChALkeR closed this Oct 9, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@reggi@ChALkeR@silverwind@targos