Uh oh!
There was an error while loading. Please reload this page.
src: sync access for report and openssl options - #32618
Closed
sam-github wants to merge 1 commit into
Closed
Conversation
addaleax
approved these changes
Apr 2, 2020
jasnell
approved these changes
Apr 2, 2020
nodejs-github-bot
commented
Apr 2, 2020
Collaborator
cjihrig
approved these changes
Apr 2, 2020
3 tasks
cjihrig
reviewed
Apr 3, 2020
Uh oh!
There was an error while loading. Please reload this page.
gireeshpunathil
approved these changes
Apr 3, 2020
gireeshpunathil
commented
Apr 3, 2020
Member
(Outside of this PR, but because we are here) does it makes sense to have an internal document which contain:
|
Codecov Report
@@ Coverage Diff @@## master #32618 +/- ##
=======================================
Coverage 97.54% 97.55% =======================================
Files 195 195 Lines 65834 65811 -23 =======================================
- Hits 64218 64201 -17 + Misses 1616 1610 -6
Continue to review full report at Codecov.
|
nodejs-github-bot
commented
Apr 5, 2020
Collaborator
Audited usage of per-process OpenSSL and Report options, adding two required mutexes. Also documented existence and typical use of the per-process cli option mutex.
nodejs-github-bot
commented
Apr 6, 2020
Collaborator
nodejs-github-bot
commented
Apr 7, 2020
Collaborator
addaleax pushed a commit
that referenced
this pull request
Apr 8, 2020
Audited usage of per-process OpenSSL and Report options, adding two required mutexes. Also documented existence and typical use of the per-process cli option mutex. PR-URL: #32618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax
commented
Apr 8, 2020
Member
Landed in fcde1de |
targos pushed a commit
that referenced
this pull request
Apr 12, 2020
Audited usage of per-process OpenSSL and Report options, adding two required mutexes. Also documented existence and typical use of the per-process cli option mutex. PR-URL: #32618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit
that referenced
this pull request
Apr 14, 2020
Audited usage of per-process OpenSSL and Report options, adding two required mutexes. Also documented existence and typical use of the per-process cli option mutex. PR-URL: #32618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
4 tasks
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Audited usage of per-process OpenSSL and Report options, adding two required mutexes. Also documented existence and typical use of the per-process cli option mutex. PR-URL: nodejs#32618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Audited usage of per-process OpenSSL and Report options, adding two required mutexes. Also documented existence and typical use of the per-process cli option mutex. PR-URL: #32618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.
Also documented existence and typical use of the per-process cli option
mutex.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes