Uh oh!
There was an error while loading. Please reload this page.
doc: replace node-test-pull-request-lite-pipeline from onboarding - #32736
Closed
juanarbol wants to merge 1 commit into
Closed
doc: replace node-test-pull-request-lite-pipeline from onboarding#32736juanarbol wants to merge 1 commit into
juanarbol wants to merge 1 commit into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request.
juanarbolforce-pushed
the
juanarbol/onboarding-changes
branch
from
April 9, 2020 13:39
8c7825e to
12b7f00Comparerichardlau
approved these changes
Apr 9, 2020
Trott
reviewed
Apr 9, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott
approved these changes
Apr 9, 2020
jasnell
approved these changes
Apr 10, 2020
himself65
approved these changes
Apr 11, 2020
nodejs-github-bot
commented
Apr 11, 2020
Collaborator
nodejs-github-bot
commented
Apr 11, 2020
Collaborator
Trott
commented
Apr 11, 2020
Member
Because this is a documentation-only change, it does not need to pass Jenkins. Passing the GitHub Actions tests is sufficient per https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#testing-and-ci. |
Trott
commented
Apr 11, 2020
Member
Landed in 5c53538 |
Trott pushed a commit
that referenced
this pull request
Apr 11, 2020
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: #32736 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit
that referenced
this pull request
Apr 13, 2020
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: #32736 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
BethGriggs pushed a commit
that referenced
this pull request
Apr 14, 2020
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: #32736 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit
that referenced
this pull request
Apr 22, 2020
Replace the obsolete node-test-pull-request-lite-pipeline CI task in favour of node-test-pull-request. PR-URL: #32736 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the obsolete node-test-pull-request-lite-pipeline CI
task in favour of node-test-pull-request-pipeline.
I've updated the docs based on this comment
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes