Uh oh!
There was an error while loading. Please reload this page.
test: refactor events tests for invalid listeners - #32769
Closed
edsadr wants to merge 1 commit into
Closed
Conversation
addaleax
approved these changes
Apr 10, 2020
gireeshpunathil
approved these changes
Apr 11, 2020
nodejs-github-bot
commented
Apr 11, 2020
Collaborator
richardlau
commented
Apr 11, 2020
Member
How easy will it be in the event of failure to determine which event was the cause? |
edsadrforce-pushed
the
edsadr/test-event-emitter-invalid-listener
branch
from
April 11, 2020 18:16
1ae50b5 to
13e3442Compareedsadr
commented
Apr 11, 2020
ContributorAuthor
great catch @richardlau, just added a custom message per assertion revealing the method being tested, so if one fails you will have clarity which one was |
Flarna
approved these changes
Apr 11, 2020
richardlau
approved these changes
Apr 11, 2020
nodejs-github-bot
commented
Apr 14, 2020
Collaborator
nodejs-github-bot
commented
Apr 15, 2020
Collaborator
nodejs-github-bot
commented
Apr 17, 2020
Collaborator
nodejs-github-bot
commented
Apr 18, 2020
Collaborator
addaleax pushed a commit
that referenced
this pull request
Apr 24, 2020
PR-URL: #32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
commented
Apr 24, 2020
Member
Landed in cea853c 💙 |
BethGriggs pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #32769 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactor some duplicated assertions in different event-emitter tests to a single one
make -j4 test(UNIX), orvcbuild test(Windows) passes