Skip to content

tls: connect supports highWaterMark option - #32786

Closed
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:https-highWaterMark
Closed

tls: connect supports highWaterMark option#32786
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:https-highWaterMark

Conversation

@rickyes

@rickyesrickyes commented Apr 11, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

fixes: #32781

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Apr 11, 2020
@addaleax

addaleax commented Apr 11, 2020

Copy link
Copy Markdown
Member

@rickyes A few things:

  • This is missing a documentation update, I think? I think both a change to the documentation and a changes: entry make sense here?
  • Does this really affect only HTTPS like the commit message implies? It looks like it affects all TLS connections? In that case, an additional test that doesn’t use HTTPS and only TLS seems like a good idea.
  • The commit message should probably start with tls:. Generally, lib: makes sense only for very generic changes or changes that do not affect the way that the public API behaves.

addaleax
addaleax reviewed Apr 11, 2020
View reviewed changes
Comment threadtest/parallel/test-https-hwm.js Outdated
@rickyes

rickyes commented Apr 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@rickyes A few things:

  • This is missing a documentation update, I think? I think both a change to the documentation and a changes: entry make sense here?
  • Does this really affect only HTTPS like the commit message implies? It looks like it affects all TLS connections? In that case, an additional test that doesn’t use HTTPS and only TLS seems like a good idea.
  • The commit message should probably start with tls:. Generally, lib: makes sense only for very generic changes or changes that do not affect the way that the public API behaves.

Thanks for the reminder, I'll change it.

@rickyesrickyes changed the title lib: support https highWaterMarktls: support highWaterMarkApr 12, 2020
@rickyesrickyes changed the title tls: support highWaterMarktls: connect supports highWaterMark optionApr 12, 2020
@rickyes
rickyesforce-pushed the https-highWaterMark branch from 254512b to 39e9cd4CompareApril 12, 2020 03:07
@rickyes

rickyes commented Apr 12, 2020

Copy link
Copy Markdown
ContributorAuthor

@rickyes A few things:

  • This is missing a documentation update, I think? I think both a change to the documentation and a changes: entry make sense here?
  • Does this really affect only HTTPS like the commit message implies? It looks like it affects all TLS connections? In that case, an additional test that doesn’t use HTTPS and only TLS seems like a good idea.
  • The commit message should probably start with tls:. Generally, lib: makes sense only for very generic changes or changes that do not affect the way that the public API behaves.

done

@rickyes
rickyesforce-pushed the https-highWaterMark branch from 39e9cd4 to e6834c1CompareApril 12, 2020 03:21
@rickyes
rickyes requested a review from addaleaxApril 13, 2020 01:42
@rickyes

rickyes commented Apr 13, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

/cc @nodejs/crypto @jasnell

@himself65himself65 added the review wanted PRs that need reviews. label Apr 13, 2020
himself65
himself65 requested changes Apr 13, 2020
View reviewed changes
Comment threaddoc/api/tls.md Outdated
Comment threaddoc/api/https.md Outdated
himself65
himself65 reviewed Apr 13, 2020
View reviewed changes
Comment threadtest/parallel/test-https-hwm.js Outdated
@rickyes
rickyesforce-pushed the https-highWaterMark branch from e6834c1 to eb308daCompareApril 13, 2020 07:43
@rickyes
rickyes requested a review from himself65April 13, 2020 07:56
addaleax
addaleax approved these changes Apr 13, 2020
View reviewed changes
Comment threaddoc/api/https.md Outdated
Comment threaddoc/api/tls.md Outdated
Comment threadtest/parallel/test-tls-connect-hwm-option.js Outdated
@rickyes
rickyesforce-pushed the https-highWaterMark branch from eb308da to e889a5bCompareApril 13, 2020 13:07
@rickyes

rickyes commented Apr 25, 2020

Copy link
Copy Markdown
ContributorAuthor

Should be ready, can you help start a CI run ？ @addaleax@himself65

@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30976/

@rickyes

rickyes commented Apr 26, 2020

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/30976/

I think it's ready.

@ronagronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed review wanted PRs that need reviews. labels Apr 26, 2020
puzpuzpuz pushed a commit that referenced this pull request Apr 27, 2020
@rickyes@puzpuzpuz
tls: add highWaterMark option for connect
58682d8
PR-URL: #32786Fixes: #32781
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@puzpuzpuz

puzpuzpuz commented Apr 27, 2020

Copy link
Copy Markdown
Member

Landed in 58682d8

@rickyes
rickyes deleted the https-highWaterMark branch April 27, 2020 14:24
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@rickyes@BethGriggs
tls: add highWaterMark option for connect
35fcfbe
PR-URL: #32786Fixes: #32781
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@rickyes@BridgeAR
tls: add highWaterMark option for connect
efb3c71
PR-URL: #32786Fixes: #32781
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@rickyes@BridgeAR
tls: add highWaterMark option for connect
f6274af
PR-URL: #32786Fixes: #32781
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@rickyes@BethGriggs
tls: add highWaterMark option for connect
323da6f
PR-URL: #32786Fixes: #32781
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@richardlaurichardlau mentioned this pull request May 13, 2020
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@himself65himself65himself65 approved these changes
+1 more reviewer
@puzpuzpuzpuzpuzpuzpuzpuzpuz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

highWaterMark option is ignored in HTTPs request stream

8 participants

@rickyes@addaleax@nodejs-github-bot@puzpuzpuz@jasnell@himself65@targos@ronag