Uh oh!
There was an error while loading. Please reload this page.
cluster: fix error on worker disconnect/destroy - #32793
Closed
santigimeno wants to merge 1 commit into
Closed
Conversation
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: nodejs#32106
Uh oh!
There was an error while loading. Please reload this page.
himself65
approved these changes
Apr 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
addaleax
approved these changes
Apr 27, 2020
nodejs-github-bot
commented
Apr 28, 2020
Collaborator
addaleax pushed a commit
that referenced
this pull request
Apr 28, 2020
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: #32106 PR-URL: #32793 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
commented
Apr 28, 2020
Member
Landed in 73324cf |
targos pushed a commit
that referenced
this pull request
May 4, 2020
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: #32106 PR-URL: #32793 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit
that referenced
this pull request
May 7, 2020
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: #32106 PR-URL: #32793 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit
that referenced
this pull request
May 13, 2020
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: #32106 PR-URL: #32793 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid sending multiple
exitedAfterDisconnectmessages whenconcurrently calling
disconnect()and/ordestroy()from the workerso
ERR_IPC_DISCONNECTEDerrors are not generated.Not completely sure if it's something that should be fixed in the module or in the user code, but just in case...
Fixes: #32106
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes