Uh oh!
There was an error while loading. Please reload this page.
[v13.x] deps: V8: cherry-pick dc3a90be6ca7 - #32795
Closed
targos wants to merge 1 commit into
Closed
Conversation
Original commit message: [debug] Revert to old line number behavior for new Function() Reverting https://chromium-review.googlesource.com/c/v8/v8/+/1741660 This fixed one bug but caused a lot of others and on balance I think reverting it is the lesser evil. This also fixed generator-relocation.js because (function*(){}).constructor is the function constructor and we try to set a breakpoint on line 3. Bug: chromium:109362, chromium:1028689 Fixes: v8:9721 Change-Id: I1bfe6ec57ce77ea7292df91266311f5c0194947e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940259 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65232} Refs: v8/v8@dc3a90b Revert "assert: fix line number calculation after V8 upgrade" This reverts commit 5981fb7. Fixes: nodejs#32688
targos
commented
Apr 12, 2020
MemberAuthor
This includes a revert of 5981fb7, which was also done on master when we updated V8 to 8.1. |
targos
commented
Apr 16, 2020
MemberAuthor
@nodejs/v8-update |
nodejs-github-bot
commented
Apr 16, 2020
Collaborator
bnoordhuis
approved these changes
Apr 16, 2020
targos added a commit
that referenced
this pull request
Apr 28, 2020
Original commit message: [debug] Revert to old line number behavior for new Function() Reverting https://chromium-review.googlesource.com/c/v8/v8/+/1741660 This fixed one bug but caused a lot of others and on balance I think reverting it is the lesser evil. This also fixed generator-relocation.js because (function*(){}).constructor is the function constructor and we try to set a breakpoint on line 3. Bug: chromium:109362, chromium:1028689 Fixes: v8:9721 Change-Id: I1bfe6ec57ce77ea7292df91266311f5c0194947e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940259 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65232} Refs: v8/v8@dc3a90b Revert "assert: fix line number calculation after V8 upgrade" This reverts commit 5981fb7. Fixes: #32688 PR-URL: #32795 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
commented
Apr 28, 2020
MemberAuthor
Landed in ea85768 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@dc3a90b
Revert "assert: fix line number calculation after V8 upgrade"
This reverts commit 5981fb7.
Fixes: #32688
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes