Uh oh!
There was an error while loading. Please reload this page.
process: suggest --trace-warnings when printing warning - #32797
Closed
addaleax wants to merge 3 commits into
Closed
Conversation
Suggest using `--trace-warnings` or `--trace-deprecation` the first time a warning is emitted without a stack trace, similar to how we suggest `--trace-uncaught` when printing uncaught exceptions without a stack trace.
richardlau
approved these changes
Apr 12, 2020
targos
approved these changes
Apr 12, 2020
mscdex
reviewed
Apr 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
addaleax added a commit
to addaleax/node
that referenced
this pull request
Apr 12, 2020
2 tasks
nodejs-github-bot
commented
Apr 12, 2020
Collaborator
devnexen
approved these changes
Apr 12, 2020
cjihrig
approved these changes
Apr 12, 2020
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/30672/ (:white_check_mark:) |
BridgeAR
approved these changes
Apr 13, 2020
addaleax
commented
Apr 15, 2020
MemberAuthor
Landed in 907ebdd |
addaleax added a commit
that referenced
this pull request
Apr 15, 2020
Suggest using `--trace-warnings` or `--trace-deprecation` the first time a warning is emitted without a stack trace, similar to how we suggest `--trace-uncaught` when printing uncaught exceptions without a stack trace. PR-URL: #32797 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit
that referenced
this pull request
Apr 15, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 17, 2020
Suggest using `--trace-warnings` or `--trace-deprecation` the first time a warning is emitted without a stack trace, similar to how we suggest `--trace-uncaught` when printing uncaught exceptions without a stack trace. PR-URL: #32797 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
Apr 17, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
Suggest using `--trace-warnings` or `--trace-deprecation` the first time a warning is emitted without a stack trace, similar to how we suggest `--trace-uncaught` when printing uncaught exceptions without a stack trace. PR-URL: #32797 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 7, 2020
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere
commented
Jun 9, 2020
Member
@addaleax should this go back into |
addaleax
commented
Jun 9, 2020
MemberAuthor
@codebytere I’m not sure myself. @targos@cjihrig@devnexen@richardlau@BridgeAR You approved this, wdyt? |
cjihrig
commented
Jun 10, 2020
Contributor
I don't have a strong opinion one way or the other, but I would not backport this unless it starts causing a lot of problems backporting other commits. |
BridgeAR
commented
Jun 10, 2020
Member
I would backport it. Otherwise this is going to cause conflicts on each warning that is backported and it is helpful for users. |
richardlau
commented
Jun 10, 2020
Member
I agree with @cjihrig 's position. I do think the extra message is useful but it does introduce an extra line of output which, as can be seen by the test changes, can affect anything trying to parse the output of running a Node.js application. If the change breaks anything in CITGM for 12.x I'd be a hard no to backporting. |
BridgeAR
commented
Jun 10, 2020
Member
I added the don't land on 12 label due to the comments above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest using
--trace-warningsor--trace-deprecationthe firsttime a warning is emitted without a stack trace, similar to how
we suggest
--trace-uncaughtwhen printing uncaught exceptionswithout a stack trace.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes