Skip to content

vm: throw error when duplicated exportNames in SyntheticModule - #32810

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200413-vm
Closed

vm: throw error when duplicated exportNames in SyntheticModule#32810
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200413-vm

Conversation

@himself65

@himself65himself65 commented Apr 13, 2020

Copy link
Copy Markdown
Member

Fixes: #32806

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label Apr 13, 2020
@himself65
himself65 requested a review from targosApril 13, 2020 10:03
SimenB
SimenB reviewed Apr 13, 2020
View reviewed changes
Comment threadlib/internal/vm/module.js Outdated
@himself65

This comment has been minimized.

Sign in to view
targos
targos reviewed Apr 13, 2020
View reviewed changes
Comment threadlib/internal/vm/module.js Outdated
devsnek
devsnek reviewed Apr 13, 2020
View reviewed changes
Comment threadlib/internal/vm/module.js Outdated
Comment threadlib/internal/vm/module.js Outdated
devsnek
devsnek reviewed Apr 13, 2020
View reviewed changes
Comment threadtest/parallel/test-vm-module-basic.js Outdated
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30685/

@himself65himself65 changed the title vm: avoid duplicated exportNames on SyntheticModulevm: throw error when duplicated exportNames in SyntheticModuleApr 13, 2020
SimenB
SimenB reviewed Apr 13, 2020
View reviewed changes
Comment threadtest/parallel/test-vm-module-basic.js Outdated
SimenB
SimenB reviewed Apr 13, 2020
View reviewed changes
Comment threadlib/internal/vm/module.js Outdated
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31040/

himself65 added a commit that referenced this pull request Apr 28, 2020
@himself65
vm: throw error when duplicated exportNames in SyntheticModule
9545013
Fixes: #32806
PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@himself65

himself65 commented Apr 28, 2020

Copy link
Copy Markdown
MemberAuthor

landed in 9545013

targos pushed a commit that referenced this pull request May 4, 2020
@himself65@targos
vm: throw error when duplicated exportNames in SyntheticModule
4423304
Fixes: #32806
PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@himself65@targos
vm: throw error when duplicated exportNames in SyntheticModule
8b4c57f
Fixes: #32806
PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@himself65@targos
vm: throw error when duplicated exportNames in SyntheticModule
6a9f867
Fixes: #32806
PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
+2 more reviewers
@SimenBSimenBSimenB left review comments
@devsnekdevsnekdevsnek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SyntheticModule aborts with illegal hardware instruction during linking

6 participants

@himself65@nodejs-github-bot@addaleax@SimenB@targos@devsnek