Skip to content

src: remove validation of unreachable code - #32818

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juanarbol/node_os-validation
Closed

src: remove validation of unreachable code#32818
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juanarbol/node_os-validation

Conversation

@juanarbol

@juanarboljuanarbol commented Apr 13, 2020

Copy link
Copy Markdown
Member

Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@juanarbol
src: remove validation of unreachable code
43e857c
Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. labels Apr 13, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2020•
edited by juanarbol
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30689/ ( ✔️ )

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2020
@juanarbol

juanarbol commented Apr 13, 2020

Copy link
Copy Markdown
MemberAuthor

I think this needs a quick update, it should be unsigned int amount, instead of double amount, if I am right, I can write that little "fix"

@addaleax

addaleax commented Apr 13, 2020

Copy link
Copy Markdown
Member

@juanarbol The current code is correct – we want the returned value to be a JS number, which corresponds to double in C++. The assignment to double amount = ... does the conversion implicitly, which is fine for us (although you could add static_cast<double>(...) to make it more explicit).

If we did use unsigned int amount, the amount value would be truncated to the size of an unsigned int, which is typically 32 bits; but the value returned from libuv won’t usually fit into that range, so we’d actually get a wrong result in that case.

@juanarbol

juanarbol commented Apr 13, 2020

Copy link
Copy Markdown
MemberAuthor

I think it is ok now, thank you @addaleax !!!

@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2020•
edited by juanarbol
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30843/ ❌

juanarbol added a commit that referenced this pull request Apr 19, 2020
@juanarbol
src: remove validation of unreachable code
250060a
Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.
PR-URL: #32818
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@juanarbol

juanarbol commented Apr 19, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 250060a

BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@juanarbol@BethGriggs
src: remove validation of unreachable code
f9b8988
Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.
PR-URL: #32818
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol@BridgeAR
src: remove validation of unreachable code
c1f54c7
Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.
PR-URL: #32818
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@juanarbol@targos
src: remove validation of unreachable code
0745f88
Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.
PR-URL: #32818
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targostargos mentioned this pull request May 2, 2020
Merged
@juanarbol
juanarbol deleted the juanarbol/node_os-validation branch January 19, 2021 16:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@codebyterecodebyterecodebytere approved these changes
@cjihrigcjihrigcjihrig approved these changes
@himself65himself65himself65 approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.osIssues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@juanarbol@nodejs-github-bot@addaleax@bnoordhuis@jasnell@codebytere@cjihrig@devsnek@himself65@ZYSzys