Uh oh!
There was an error while loading. Please reload this page.
test: mark cpu-prof-dir-worker flaky on all - #32828
Closed
sam-github wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Apr 13, 2020
Collaborator
addaleax
approved these changes
Apr 13, 2020
cjihrig
approved these changes
Apr 13, 2020
MylesBorins
commented
Apr 14, 2020
Contributor
fast-track? |
MylesBorins
approved these changes
Apr 14, 2020
sam-github
commented
Apr 14, 2020
ContributorAuthor
Also failed CI.... build from tarball is flaky? #32848 Looks like a linux containerd build was killed for OOM reasons on a debug build (famously memory hungry): https://ci.nodejs.org/job/node-test-commit-linux-containered/19491/nodes=ubuntu1804_sharedlibs_debug_x64/console |
nodejs-github-bot
commented
Apr 14, 2020
Collaborator
sam-githubforce-pushed
the
flaky-test-cpu-prof-dir-worker
branch
from
April 14, 2020 18:00
c77eb40 to
bf6de93Comparenodejs-github-bot
commented
Apr 14, 2020
Collaborator
Trott
approved these changes
Apr 15, 2020
Trott
commented
Apr 15, 2020
Member
Landed in 3f5142d |
Trott pushed a commit
that referenced
this pull request
Apr 15, 2020
Refs: #27611 (comment) PR-URL: #32828 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 17, 2020
Refs: #27611 (comment) PR-URL: #32828 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Refs: nodejs#27611 (comment) PR-URL: nodejs#32828 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: #27611 (comment) PR-URL: #32828 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: #27611 (comment) PR-URL: #32828 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #27611 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes