Skip to content

test: flaky test-stdout-close-catch on freebsd - #32849

Closed
sam-github wants to merge 2 commits into
nodejs:masterfrom
sam-github:flaky-test-stdout-close-catch
Closed

test: flaky test-stdout-close-catch on freebsd#32849
sam-github wants to merge 2 commits into
nodejs:masterfrom
sam-github:flaky-test-stdout-close-catch

Conversation

@sam-github

@sam-githubsam-github commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

Refs: #28803

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Apr 14, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30732/

@sam-githubsam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2020
@sam-github

sam-github commented Apr 14, 2020

Copy link
Copy Markdown
ContributorAuthor

can I fast track?

@sam-github
test: flaky test-stdout-close-catch on freebsd
d33f75b
Refs: nodejs#28803
@sam-github
test: mark flaky on freebsd
a4c4087
Test name test-worker-message-port-message-before-close is too long for
a commit message description.
Refs: nodejs#31280
@sam-github
sam-githubforce-pushed the flaky-test-stdout-close-catch branch from 5b413a5 to a4c4087CompareApril 17, 2020 21:50
juanarbol
juanarbol approved these changes Apr 20, 2020
View reviewed changes

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31041/

addaleax pushed a commit that referenced this pull request Apr 28, 2020
@sam-github@addaleax
test: flaky test-stdout-close-catch on freebsd
22192fc
Refs: #28803
PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Apr 28, 2020
@sam-github@addaleax
test: mark test flaky on freebsd
8e956f4
Test name test-worker-message-port-message-before-close is too long for
a commit message description.
Refs: #31280
PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax

addaleax commented Apr 28, 2020

Copy link
Copy Markdown
Member

Landed in 1d0b249...8e956f4

targos pushed a commit that referenced this pull request May 4, 2020
@sam-github@targos
test: flaky test-stdout-close-catch on freebsd
aced1f5
Refs: #28803
PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 4, 2020
@sam-github@targos
test: mark test flaky on freebsd
f79ef96
Test name test-worker-message-port-message-before-close is too long for
a commit message description.
Refs: #31280
PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@sam-github@targos
test: flaky test-stdout-close-catch on freebsd
086357e
Refs: #28803
PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 7, 2020
@sam-github@targos
test: mark test flaky on freebsd
fd7db6a
Test name test-worker-message-port-message-before-close is too long for
a commit message description.
Refs: #31280
PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@sam-github@targos
test: flaky test-stdout-close-catch on freebsd
4ab6643
Refs: #28803
PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 13, 2020
@sam-github@targos
test: mark test flaky on freebsd
dad8217
Test name test-worker-message-port-message-before-close is too long for
a commit message description.
Refs: #31280
PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau pushed a commit that referenced this pull request Jul 1, 2020
@sam-github@richardlau
test: flaky test-stdout-close-catch on freebsd
5436569
Refs: #28803
PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlaurichardlau mentioned this pull request Jul 2, 2020
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sam-github@nodejs-github-bot@addaleax@jasnell@lpinca@richardlau@BridgeAR@juanarbol