Uh oh!
There was an error while loading. Please reload this page.
use for-of in Readable.from - #32855
Closed
vadzim wants to merge 1 commit into
Closed
Conversation
3 tasks
vadzimforce-pushed
the
UseForOfInReadableFrom
branch
2 times, most recently
from
April 14, 2020 22:41
8cee490 to
9355470CompareUse for-of loop to traverse iterator and properly close it if not all of its values are consumed. Fixes: nodejs#32842
vadzimforce-pushed
the
UseForOfInReadableFrom
branch
from
April 14, 2020 22:41
9355470 to
125ba87Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes