Uh oh!
There was an error while loading. Please reload this page.
test: changed function to arrow function - #32875
Closed
nimit95 wants to merge 1 commit into
Closed
Conversation
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required.
nimit95
commented
Apr 16, 2020
ContributorAuthor
Some unrelated test broke on macOS |
gireeshpunathil
approved these changes
Apr 16, 2020
nodejs-github-bot
commented
Apr 16, 2020
Collaborator
addaleax
approved these changes
Apr 16, 2020
cjihrig
approved these changes
Apr 16, 2020
nodejs-github-bot
commented
Apr 16, 2020
Collaborator
nimit95
commented
Apr 16, 2020
ContributorAuthor
test/parallel/test-worker-init-failure.js, do we know is this test flaky. |
jasnell
approved these changes
Apr 17, 2020
BridgeAR
approved these changes
Apr 17, 2020
BridgeAR
commented
Apr 17, 2020
Member
@nimit95 yes, there are a couple flaky tests. It's unrelated to this change :) |
gireeshpunathil pushed a commit
that referenced
this pull request
Apr 18, 2020
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: #32875 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gireeshpunathil
commented
Apr 18, 2020
Member
landed in 4986286 |
BethGriggs pushed a commit
that referenced
this pull request
Apr 27, 2020
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: #32875 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: #32875 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos pushed a commit
that referenced
this pull request
Apr 30, 2020
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: #32875 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert callback functions that are anonymous
to arrow functions for better readability.
Also adjusted the
thisobject in placeswhere that was required.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes