Skip to content

doc: fix typo in security-release-process.md - #32926

Closed
SASUKE40 wants to merge 1 commit into
nodejs:masterfrom
SASUKE40:20200419-typo
Closed

doc: fix typo in security-release-process.md#32926
SASUKE40 wants to merge 1 commit into
nodejs:masterfrom
SASUKE40:20200419-typo

Conversation

@SASUKE40

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 19, 2020
Comment threaddoc/guides/security-release-process.md Outdated
@SASUKE40SASUKE40 changed the title doc: fix typos in security-release-process.mddoc: fix typo in security-release-process.mdApr 20, 2020

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@juanarboljuanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

juanarbol pushed a commit that referenced this pull request Apr 21, 2020
PR-URL: #32926
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol

Copy link
Copy Markdown
Member

Amazing, nice job.

Landed in 438514d 🎉

BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
PR-URL: #32926
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32926
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
targos pushed a commit that referenced this pull request Apr 30, 2020
PR-URL: #32926
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targostargos mentioned this pull request May 2, 2020
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32926
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@SASUKE40@nodejs-github-bot@juanarbol@jasnell@cjihrig@devnexen@himself65@MrHeer