Uh oh!
There was an error while loading. Please reload this page.
stream: don't emit finish after close - #32933
Closed
ronag wants to merge 6 commits into
Closed
Conversation
ronagforce-pushed
the
stream-finish-after-close
branch
3 times, most recently
from
April 19, 2020 21:57
8bf2442 to
ec3e537Compareronag
commented
Apr 22, 2020
MemberAuthor
@nodejs/streams |
lpinca
approved these changes
Apr 22, 2020
mcollina
left a comment
Member
There was a problem hiding this comment.
Given that the PR mention 'close', it would be good to add a few mustCall()/mustNotCall() for that as well.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed
the
stream-finish-after-close
branch
from
April 25, 2020 17:35
f9154ec to
604191bCompareronag
commented
Apr 25, 2020
MemberAuthor
added some missing mustCalls |
Writable stream could emit 'finish' after 'close'.
ronagforce-pushed
the
stream-finish-after-close
branch
from
April 25, 2020 17:37
604191b to
7da4656Comparenodejs-github-bot
commented
Apr 25, 2020
Collaborator
nodejs-github-bot
commented
Apr 25, 2020
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed
the
stream-finish-after-close
branch
from
April 26, 2020 09:09
065eb38 to
706e189Comparenodejs-github-bot
commented
Apr 27, 2020
Collaborator
ronag added a commit
that referenced
this pull request
Apr 27, 2020
Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ronag
commented
Apr 27, 2020
MemberAuthor
Landed in f5c11a1 |
BethGriggs pushed a commit
that referenced
this pull request
Apr 27, 2020
Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
ronag
commented
Apr 28, 2020
MemberAuthor
4 tasks
targos
commented
May 16, 2021
Member
4 tasks
ronag
commented
May 16, 2021
MemberAuthor
Yes. I'm a little overloaded at the moment though. If you need help ping me again in a. week :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writable stream could emit 'finish' after 'close'.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes