Skip to content

stream: consistent punctuation - #32934

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-punctuation
Closed

stream: consistent punctuation#32934
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-punctuation

Conversation

@ronag

Copy link
Copy Markdown
Member

Cleanup comments to use consistent punctuation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@ronag
ronag requested a review from BridgeARApril 19, 2020 21:38
@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 19, 2020
@ronag
ronag requested a review from benjamingrApril 19, 2020 21:38
@ronagronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Cleanup comments to use consistent punctuation.
@ronag

Copy link
Copy Markdown
MemberAuthor

rebased to fix conflicts

@ronag
ronagforce-pushed the stream-punctuation branch from f7fde21 to 7134775CompareApril 23, 2020 17:55
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@ronag

Copy link
Copy Markdown
MemberAuthor

Landed in 802edb1

@ronagronag closed this Apr 24, 2020
ronag added a commit that referenced this pull request Apr 24, 2020
Cleanup comments to use consistent punctuation.
PR-URL: #32934
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
Cleanup comments to use consistent punctuation.
PR-URL: #32934
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Cleanup comments to use consistent punctuation.
PR-URL: #32934
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@ronag@nodejs-github-bot@addaleax@benjamingr@lpinca@BridgeAR@trivikr@juanarbol@MrHeer@Flarna@targos