Uh oh!
There was an error while loading. Please reload this page.
stream: removes unused params - #32936
Closed
JesuHrz wants to merge 1 commit into
Closed
Conversation
lpinca
approved these changes
Apr 20, 2020
nodejs-github-bot
commented
Apr 20, 2020
Collaborator
lpinca
commented
Apr 20, 2020
Member
Subsystem in commit message should be "stream" not "lib". |
Removes the state param in the onFinished function since it's never used within it.
JesuHrzforce-pushed
the
jesuhrz/removes-unused-params
branch
from
April 20, 2020 19:34
d7dc43c to
22fdc41CompareJesuHrz
commented
Apr 20, 2020
ContributorAuthor
thanks @lpinca for the feedback, I just made this change |
Flarna
approved these changes
Apr 20, 2020
nodejs-github-bot
commented
Apr 21, 2020
Collaborator
nodejs-github-bot
commented
Apr 24, 2020
Collaborator
nodejs-github-bot
commented
Apr 24, 2020
Collaborator
nodejs-github-bot
commented
Apr 24, 2020
Collaborator
addaleax
commented
Apr 25, 2020
Member
Landed in 24a4e61 |
addaleax pushed a commit
that referenced
this pull request
Apr 25, 2020
Removes the state param in the onFinished function since it's never used within it. PR-URL: #32936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs pushed a commit
that referenced
this pull request
Apr 27, 2020
Removes the state param in the onFinished function since it's never used within it. PR-URL: #32936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
Removes the state param in the onFinished function since it's never used within it. PR-URL: #32936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
stateparam in theonFinishedfunctionsince it's never used within it.
make -j4 test(UNIX), orvcbuild test(Windows) passes