Skip to content

path: fix comment grammar - #32942

Closed
thecodrr wants to merge 1 commit into
nodejs:masterfrom
thecodrr:grammar
Closed

path: fix comment grammar#32942
thecodrr wants to merge 1 commit into
nodejs:masterfrom
thecodrr:grammar

Conversation

@thecodrr

Copy link
Copy Markdown
Contributor

Hi, this is my first PR.

I was looking through the path.js source code and saw some grammar mistakes in one of the comments. Thought it would make a good first PR.

Checklist

@nodejs-github-botnodejs-github-bot added the path Issues and PRs related to the path subsystem. label Apr 20, 2020
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

addaleax pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@addaleax

Copy link
Copy Markdown
Member

Landed in d0377a8 🎉

Thanks for being patient with us!

targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@targostargos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@targostargos mentioned this pull request May 7, 2020
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.pathIssues and PRs related to the path subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thecodrr@nodejs-github-bot@addaleax@devsnek@MrHeer