Skip to content

doc: add more info to v14 changelog - #32979

Closed
devsnek wants to merge 0 commit into
masterfrom
devsnek-patch-1
Closed

doc: add more info to v14 changelog#32979
devsnek wants to merge 0 commit into
masterfrom
devsnek-patch-1

Conversation

@devsnek

@devsnekdevsnek commented Apr 21, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 21, 2020
jasnell
jasnell approved these changes Apr 21, 2020
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A corresponding update should be made on the blog post: https://github.com/nodejs/nodejs.org/blob/master/locale/en/blog/release/v14.0.0.md

@devsnek

devsnek commented Apr 21, 2020

Copy link
Copy Markdown
MemberAuthor

What are the rules on merging doc-only changes?

@GaryGSC

GaryGSC commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#waiting-for-approvals

To propose fast-tracking a pull request, apply the fast-track label. Then add a comment that Collaborators may upvote.

@jasnell

jasnell commented Apr 21, 2020

Copy link
Copy Markdown
Member

In general, the rules are the same as any commit unless fast-track is ok'd by at least two collaborators.

@devsnekdevsnek added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 21, 2020
@devsnek

devsnek commented Apr 21, 2020

Copy link
Copy Markdown
MemberAuthor

👍 to fast track?

@richardlau

richardlau commented Apr 21, 2020

Copy link
Copy Markdown
Member

What are the rules on merging doc-only changes?

https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#testing-and-ci

Pull requests that only change documentation and comments can use GitHub Actions results.

i.e. doc-only changes do not require Jenkins CI to be run but do require the GitHub Actions to pass.

devsnek added a commit that referenced this pull request Apr 22, 2020
@devsnek
doc: add more info to v14 changelog
d08bd41
PR-URL: #32979
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@devsnekdevsnek closed this Apr 22, 2020
@devsnek
devsnek deleted the devsnek-patch-1 branch April 22, 2020 03:16
@devsnek

devsnek commented Apr 22, 2020

Copy link
Copy Markdown
MemberAuthor

landed in d08bd41

BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@devsnek@BethGriggs
doc: add more info to v14 changelog
b5b3efe
PR-URL: #32979
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@devsnek@GaryGSC@jasnell@richardlau@lpinca@cjihrig@gengjiawen@BridgeAR@targos@nodejs-github-bot