Uh oh!
There was an error while loading. Please reload this page.
module: refactor condition - #32989
Closed
MylesBorins wants to merge 1 commit into
Closed
Conversation
himself65
approved these changes
Apr 22, 2020
cjihrig
approved these changes
Apr 22, 2020
puzpuzpuz
approved these changes
Apr 22, 2020
nodejs-github-bot
commented
Apr 25, 2020
Collaborator
MrHeer
approved these changes
Apr 25, 2020
nodejs-github-bot
commented
Apr 25, 2020
Collaborator
nodejs-github-bot
commented
Apr 26, 2020
Collaborator
addaleax
commented
Apr 27, 2020
Member
Landed in 2439071 |
addaleax pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
targos pushed a commit
that referenced
this pull request
May 13, 2020
PR-URL: #32989 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this when reviewing the code I had just landed... the two conditions were equivalent and could be simplified.