Skip to content

module: hide internal stack when emitCircularRequireWarning - #32991

Closed
himself65 wants to merge 2 commits into
nodejs:masterfrom
himself65:2020-04-22-emitError
Closed

module: hide internal stack when emitCircularRequireWarning#32991
himself65 wants to merge 2 commits into
nodejs:masterfrom
himself65:2020-04-22-emitError

Conversation

@himself65

@himself65himself65 commented Apr 22, 2020

Copy link
Copy Markdown
Member

Fixes: #32987
Refs: #29935

previously:

>node--trace-warningsa(node:19168) Warning: Accessingnon-existentproperty'foo'ofmoduleexportsinsidecirculardependencyatemitCircularRequireWarning(internal/modules/cjs/loader.js:814:11)atObject.get(internal/modules/cjs/loader.js:825:5)atObject.<anonymous>(C:\Users\Himself65\Desktop\github\test\cycle\c.js:4:10)atModule._compile(internal/modules/cjs/loader.js:1185:30)atObject.Module._extensions..js(internal/modules/cjs/loader.js:1205:10)atModule.load(internal/modules/cjs/loader.js:1034:32)atFunction.Module._load(internal/modules/cjs/loader.js:923:14)atModule.require(internal/modules/cjs/loader.js:1074:19)atrequire(internal/modules/cjs/helpers.js:72:18)atObject.<anonymous>(C:\Users\Himself65\Desktop\github\test\cycle\b.js:1:1)

now

node\Release\node.exe--trace-warnings C:\Users\Himself65\Desktop\github\test\cycle\a.js(node:18824) Warning: Accessingnon-existentproperty'foo'ofmoduleexportsinsidecirculardependencyatObject.<anonymous>(C:\Users\Himself65\Desktop\github\test\cycle\c.js:4:10)atObject.<anonymous>(C:\Users\Himself65\Desktop\github\test\cycle\b.js:1:1)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@himself65himself65 added the wip Issues and PRs that are still a work in progress. label Apr 22, 2020
@nodejs-github-botnodejs-github-bot added the process Issues and PRs related to the process subsystem. label Apr 22, 2020
@himself65himself65 changed the title module: hide internal stack when onWarningmodule: hide internal stack when emitCircularRequireWarningApr 22, 2020
@gengjiawen

Copy link
Copy Markdown
Member

I think the internal stacktrace okay with me, don't see a reason to remove it.

@himself65

Copy link
Copy Markdown
MemberAuthor

Seems right, it okay with displaying internal stack

@himself65
himself65 deleted the 2020-04-22-emitError branch April 22, 2020 07:20
@himself65himself65 removed the wip Issues and PRs that are still a work in progress. label Apr 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

processIssues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node 14 with warning (node:31518) Warning: Accessing non-existent property 'column' of module exports inside circular dependency

3 participants

@himself65@gengjiawen@nodejs-github-bot