Uh oh!
There was an error while loading. Please reload this page.
lib: simplify function process.emitWarning - #32992
Closed
himself65 wants to merge 1 commit into
Closed
Conversation
mscdex
reviewed
Apr 22, 2020
Uh oh!
There was an error while loading. Please reload this page.
himself65force-pushed
the
20200422-simplify
branch
from
April 22, 2020 10:54
42ac86e to
46a3926Comparetargos
approved these changes
Apr 22, 2020
cjihrig
approved these changes
Apr 22, 2020
puzpuzpuz
approved these changes
Apr 22, 2020
BridgeAR
approved these changes
Apr 22, 2020
nodejs-github-bot
commented
Apr 23, 2020
Collaborator
juanarbol
approved these changes
Apr 23, 2020
jasnell
approved these changes
Apr 23, 2020
puzpuzpuz pushed a commit
that referenced
this pull request
Apr 24, 2020
PR-URL: #32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
puzpuzpuz
commented
Apr 24, 2020
Member
Landed in d01a06a |
BethGriggs pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32992 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes