Skip to content

deps: V8: backport 3f8dc4b2e5ba - #32993

Closed
ryzokuken wants to merge 1 commit into
nodejs:masterfrom
ryzokuken:v8-icu-67
Closed

deps: V8: backport 3f8dc4b2e5ba#32993
ryzokuken wants to merge 1 commit into
nodejs:masterfrom
ryzokuken:v8-icu-67

Conversation

@ryzokuken

@ryzokukenryzokuken commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

Original commit message:

[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}

Refs: v8/v8@3f8dc4b

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @targos@mmarchini@srl295

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Apr 22, 2020
@ryzokukenryzokuken self-assigned this Apr 22, 2020
richardlau
richardlau reviewed Apr 23, 2020
View reviewed changes
Comment threadcommon.gypi Outdated
srl295
srl295 approved these changes Apr 23, 2020
View reviewed changes

@srl295srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Icu 67.1 imminent!

@ryzokuken

ryzokuken commented Apr 27, 2020

Copy link
Copy Markdown
ContributorAuthor

@richardlau done, PTAL. I'll land this later today after your LG.

@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31000/

@targos

targos commented Apr 27, 2020

Copy link
Copy Markdown
Member

@ryzokuken you need to rebase, there's a conflict

@ryzokuken
deps: V8: backport 3f8dc4b2e5ba
19e8c4a
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
@ryzokuken

ryzokuken commented Apr 27, 2020

Copy link
Copy Markdown
ContributorAuthor

@targos done :D

@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31001/

@ryzokuken

ryzokuken commented Apr 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Is V8 CI okay, or am I doing something wrong? https://ci.nodejs.org/job/node-test-commit-v8-linux/3070/console

@targos

targos commented Apr 27, 2020

Copy link
Copy Markdown
Member

@ryzokukenGIT_REMOTE_REF should be refs/pull/32993/head

@ryzokuken

ryzokuken commented Apr 27, 2020

Copy link
Copy Markdown
ContributorAuthor

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3071/

@ryzokuken

ryzokuken commented Apr 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Both builds were successful, landing this.

ryzokuken added a commit that referenced this pull request Apr 27, 2020
@ryzokuken
deps: V8: backport 3f8dc4b2e5ba
b37ec37
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
PR-URL: #32993
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ryzokuken

ryzokuken commented Apr 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Landed in b37ec37

BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@ryzokuken@BethGriggs
deps: V8: backport 3f8dc4b2e5ba
7a9538a
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
PR-URL: #32993
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@ryzokuken@BridgeAR
deps: V8: backport 3f8dc4b2e5ba
3956ab5
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
PR-URL: #32993
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@ryzokuken@BridgeAR
deps: V8: backport 3f8dc4b2e5ba
5caa627
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
PR-URL: #32993
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeARBridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@ryzokuken@BethGriggs
deps: V8: backport 3f8dc4b2e5ba
b50333e
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
PR-URL: #32993
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Apr 30, 2020
@ryzokuken@targos
deps: V8: backport 3f8dc4b2e5ba
68787ab
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
PR-URL: #32993
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targostargos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@ryzokuken@targos
deps: V8: backport 3f8dc4b2e5ba
eb33d52
Original commit message:
[intl] Remove soon-to-be removed getAllFieldPositions
Needed to land ICU67.1 soon.
Bug: v8:10393
Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67027}
Refs: v8/v8@3f8dc4b
PR-URL: #32993
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295srl295srl295 approved these changes
@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ryzokukenryzokuken

Labels

buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ryzokuken@nodejs-github-bot@targos@srl295@mmarchini@richardlau