Uh oh!
There was an error while loading. Please reload this page.
stream: avoid unnecessary concat of a single buffer. - #3300
Closed
calvinmetcalf wants to merge 1 commit into
Closed
Conversation
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it.
calvinmetcalf
commented
Oct 9, 2015
ContributorAuthor
now featuring a correctly spelled 'unnecessary' |
mafintosh
commented
Oct 9, 2015
Member
Nice catch! +1 in this change |
jamestalmage
commented
Oct 9, 2015
👍 |
chrisdickinson
commented
Oct 11, 2015
Contributor
LGTM! |
ronkorving
commented
Oct 14, 2015
Contributor
👍 |
jasnell
commented
Oct 14, 2015
Member
jasnell
commented
Oct 14, 2015
Member
LGTM so long as CI is green |
jasnell
commented
Oct 14, 2015
Member
CI pass looks good. Two unrelated failures. |
calvinmetcalf
commented
Oct 14, 2015
ContributorAuthor
🎉 |
jasnell pushed a commit
that referenced
this pull request
Oct 14, 2015
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3300
jasnell
commented
Oct 14, 2015
Member
Landed in 8854183 |
jasnell pushed a commit
that referenced
this pull request
Oct 26, 2015
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3300
jasnell pushed a commit
that referenced
this pull request
Oct 29, 2015
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3300
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced May 13, 2024
This was referenced May 22, 2024
This was referenced May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. As pointed out in nodejs/readable-stream#162 this causes an unnecessary copy.