Uh oh!
There was an error while loading. Please reload this page.
stream: fix broken pipeline test - #33030
Closed
ronag wants to merge 1 commit into
Closed
Conversation
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. nodejs#32967 changes so that pipeline does not wait for 'close'. nodejs#32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback.
nodejs-github-bot
commented
Apr 23, 2020
Collaborator
jasnell
approved these changes
Apr 23, 2020
ronag
commented
Apr 23, 2020
MemberAuthor
@nodejs/streams |
ronag
commented
Apr 23, 2020
MemberAuthor
fast track? |
jasnell
commented
Apr 23, 2020
Member
CI is broken right now without this change so assuming it's the right change to make, we should fast-track this. |
BridgeAR
approved these changes
Apr 23, 2020
Collaborator
ronag
commented
Apr 23, 2020
MemberAuthor
I think this PR can land given fast track. However, as I'm unsure I would like to request that a more experienced collaborator lands this as fast tracked. |
BridgeAR
commented
Apr 23, 2020
Member
@ronag it needs one more +1 to fast track it (it requires 2). |
jasnell
commented
Apr 23, 2020
Member
BridgeAR pushed a commit
that referenced
this pull request
Apr 23, 2020
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. #32967 changes so that pipeline does not wait for 'close'. #32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: #33030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
commented
Apr 23, 2020
Member
Landed in 3140fdc 🎉 |
BethGriggs pushed a commit
that referenced
this pull request
Apr 27, 2020
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. #32967 changes so that pipeline does not wait for 'close'. #32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: #33030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
commented
Apr 28, 2020
Member
Should this be backported to v12? It does rely upon other commits that would have to be backported first. |
targos
commented
Apr 28, 2020
Member
@BridgeAR don't try to update v12, I have a wip branch that I will push to staging after the release of 12.16.3 today |
BridgeAR
commented
Apr 28, 2020
Member
@targos I did not plan on doing that, I just wanted to add the label, if applicable. |
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. #32967 changes so that pipeline does not wait for 'close'. #32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: #33030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unfortunate overlap between two PR that by themselves pass
CI but together fail a test.
#32967 changes so that pipeline does not wait for 'close' on Duplex streams when only interested in one side.
#32968 changed so that all streams are not destroyed.
Which together made one test fail which expected the stream to be
destroyed before pipeline callback.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes