[v12.x] Backport unflag --experimental-modules by targos · Pull Request #33055 · nodejs/node

targos · 2020-04-25T12:15:24Z

/cc @nodejs/modules-active-members @nodejs/lts

targos · 2020-04-25T12:16:35Z

This is to prepare the next v12.x minor, which is scheduled for 2020-05-26

ljharb

Does this include removal of the warning, and any other ESM bugfixes that were part of v13/v14?

ljharb · 2020-04-25T16:20:58Z

+ if (!this.exportKeys) {
+ // When using --expose-internals, we do not want to reflect the named
+ // exports from core modules as this can trigger unnecessary getters.
+ const internal = this.id.startsWith('internal/');


Suggested change
constinternal=this.id.startsWith('internal/');
constinternal=StringPrototypeStartsWith(this.id,'internal/');
i realize this is a backport PR, so maybe it should land in master with this change first, but it seems important to avoid brittleness in LTS specifically.

targos · 2020-04-25T16:30:29Z

This doesn't include the removal of the warning.
Many of the fixes are already on v12.x. This is the only PR that we did not backport in previous releases.

ljharb · 2020-04-25T16:48:33Z

Do we want it unflagged on LTS, without the warning? We removed the warning in v13 because it was inhibiting adoption; i think it would have that effect much more on an LTS version.

targos · 2020-04-25T18:06:29Z

I did not include the removal of the warning in this PR but I intend to cherry pick it as well later

MylesBorins · 2020-04-26T06:41:25Z

Please open removing the warning as a separate PR. I'm not sure that we should remove the warning on LTS prior to 14.x moving to LTS

nodejs-github-bot · 2020-04-26T07:38:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30986/

ljharb · 2020-04-26T07:43:48Z

@MylesBorins let's discuss in the next modules meeting; i'm not sure we should remove the flag without removing the warning.

MylesBorins · 2020-04-26T16:12:35Z

Totally reasonable to bring it up in the meeting. I do want to mention that we've had consensus to remove the flag for months and have been telling people we plan to do so. We have not had consensus around removing the warning.

…

On Sun, Apr 26, 2020, 3:44 AM Jordan Harband ***@***.***> wrote: @MylesBorins <https://github.com/MylesBorins> let's discuss in the next modules meeting; i'm not sure we should remove the flag without removing the warning. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33055 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYV6MHG46RX6KYHABVPDROPQ4DANCNFSM4MQXFYKA> .

richardlau · 2020-04-26T16:59:50Z

A question I have is does removing the flag potentially cause an observable change in behaviour if, say, packages had defined fields such as described/warned about in #33074? Or do package.json files with esm fields already get loaded as esm on 12.x without the experimental flag (I was under the impression they weren’t)?

ljharb · 2020-04-26T17:02:21Z

i believe any package that has opted in to use conditional exports, for example, will suddenly start to generate a warning in 12 if this lands without removing the warning - to my recollection, that experience is a big part of why we removed the warning in 13.

richardlau · 2020-04-26T18:01:51Z

My question was more around for anyone who is not currently opting in to esm but may be using dependencies that might start behaving differently once the flag is removed.

mcollina

lgtm

SimenB · 2020-05-04T12:31:15Z

Landing this will also close #33202 I guess 🙂

PR-URL: nodejs#29866 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

PR-URL: nodejs#30720 Reviewed-By: Guy Bedford <guybedford@gmail.com>

PR-URL: #29866 Backport-PR-URL: #33055 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

PR-URL: #30720 Backport-PR-URL: #33055 Reviewed-By: Guy Bedford <guybedford@gmail.com>

targos · 2020-05-07T07:00:38Z

Landed on v12.x-staging

PR-URL: #29866 Backport-PR-URL: #33055 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

PR-URL: #30720 Backport-PR-URL: #33055 Reviewed-By: Guy Bedford <guybedford@gmail.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Apr 25, 2020

GeoffreyBooth approved these changes Apr 25, 2020
View reviewed changes

ljharb reviewed Apr 25, 2020
View reviewed changes

MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 26, 2020

targos added the modules-agenda Issues and PRs to discuss during the meetings of the Modules team. label Apr 26, 2020

SimenB mentioned this pull request Apr 27, 2020
add esm bundle sinonjs/fake-timers#320
Closed

targos force-pushed the unflag-esm-v12 branch from ab9eedf to 5344ee3Compare April 28, 2020 14:31

aduh95 mentioned this pull request Apr 29, 2020
Crarify which versions support package.json:"type":"module" #33143
Closed

mhdawson mentioned this pull request May 4, 2020
Node.js Modules Team Meeting 2020-05-06 nodejs/modules#510
Closed

mcollina approved these changes May 4, 2020
View reviewed changes

codebytere approved these changes May 4, 2020
View reviewed changes

guybedfordand others added 2 commits May 6, 2020 21:17

esm: unflag --experimental-modules
e7ba623
PR-URL: nodejs#29866 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

lib: add warning on dynamic import es modules
c16d4da
PR-URL: nodejs#30720 Reviewed-By: Guy Bedford <guybedford@gmail.com>

targos force-pushed the unflag-esm-v12 branch from 5344ee3 to c16d4daCompare May 7, 2020 06:49

targos pushed a commit that referenced this pull request May 7, 2020
esm: unflag --experimental-modules
f9edab1
PR-URL: #29866 Backport-PR-URL: #33055 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

targos pushed a commit that referenced this pull request May 7, 2020
lib: add warning on dynamic import es modules
233b988
PR-URL: #30720 Backport-PR-URL: #33055 Reviewed-By: Guy Bedford <guybedford@gmail.com>

targos closed this May 7, 2020

targos deleted the unflag-esm-v12 branch May 7, 2020 07:00

aduh95 mentioned this pull request May 7, 2020
unflagging in 12.x LTS nodejs/modules#450
Closed

targos pushed a commit that referenced this pull request May 13, 2020
esm: unflag --experimental-modules
93226a5
PR-URL: #29866 Backport-PR-URL: #33055 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

targos pushed a commit that referenced this pull request May 13, 2020
lib: add warning on dynamic import es modules
698e21b
PR-URL: #30720 Backport-PR-URL: #33055 Reviewed-By: Guy Bedford <guybedford@gmail.com>

targos mentioned this pull request Jan 30, 2021
--experimental-vm-modules on Node 12 results in confusing dynamic callback error #33202
Closed

	constinternal=this.id.startsWith('internal/');
	constinternal=StringPrototypeStartsWith(this.id,'internal/');

Uh oh!

Uh oh!

Conversation

targos commented Apr 25, 2020

Uh oh!

targos commented Apr 25, 2020

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

ljharbApr 25, 2020

Choose a reason for hiding this comment

Uh oh!

targos commented Apr 25, 2020

Uh oh!

ljharb commented Apr 25, 2020

Uh oh!

targos commented Apr 25, 2020

Uh oh!

MylesBorins commented Apr 26, 2020

Uh oh!

nodejs-github-bot commented Apr 26, 2020

Uh oh!

ljharb commented Apr 26, 2020

Uh oh!

MylesBorins commented Apr 26, 2020 via email

Uh oh!

richardlau commented Apr 26, 2020

Uh oh!

ljharb commented Apr 26, 2020

Uh oh!

richardlau commented Apr 26, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

SimenB commented May 4, 2020

Uh oh!

targos commented May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants