Skip to content

tools: update ESLint to 7.0.0-rc.0 - #33062

Closed
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200425-eslint
Closed

tools: update ESLint to 7.0.0-rc.0#33062
himself65 wants to merge 1 commit into
nodejs:masterfrom
himself65:20200425-eslint

Conversation

@himself65

@himself65himself65 commented Apr 25, 2020

Copy link
Copy Markdown
Member

I mostly wanted to update eslint, cause this's my first time.

Using update-eslint.sh, I think I've well done this

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 25, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30978/

@himself65himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 26, 2020
trivikr
trivikr approved these changes Apr 27, 2020
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@himself65

himself65 commented Apr 27, 2020

Copy link
Copy Markdown
MemberAuthor

unfortunately, I cannot use git-node to land PR for now, cause it does not support system proxy 😟

@targos

targos commented Apr 27, 2020

Copy link
Copy Markdown
Member

@joyeecheung ^ How do you handle this?

@joyeecheung

joyeecheung commented Apr 27, 2020

Copy link
Copy Markdown
Member

@targos It is caused by ISP issues, I usually just switch to another ISP (e.g. tethering through my phone because my mobile ISP blocks less), or use VPN on my computer.

For git commands, git takes global proxy settings through ~/.gitconfig but git-node also have usual HTTPS requests to GitHub - these are not blocked the same way, some times connections to GitHub's git servers work while connections to some parts of github.com don't. Some people use tools like https://www.proxifier.com/ to redirect all TCP/UDP traffic in the system through a SOCKS5 server (I have not tried it). I guess we can also try adding proxy support to git-node (I see that there is already a feature request nodejs/node-core-utils#407)

himself65 added a commit that referenced this pull request Apr 28, 2020
@himself65
tools: update ESLint to 7.0.0-rc.0
039c5e4
PR-URL: #33062
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@himself65

himself65 commented Apr 28, 2020

Copy link
Copy Markdown
MemberAuthor

landed in 039c5e4

@BethGriggsBethGriggs mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@himself65@BethGriggs
tools: update ESLint to 7.0.0-rc.0
6a8e266
PR-URL: #33062
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2020
@himself65@targos
tools: update ESLint to 7.0.0-rc.0
cbadd11
PR-URL: #33062
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@himself65@targos
tools: update ESLint to 7.0.0-rc.0
1c010b4
PR-URL: #33062
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@joshuakb2joshuakb2 mentioned this pull request Jul 23, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@himself65@nodejs-github-bot@targos@joyeecheung@cjihrig@trivikr