Uh oh!
There was an error while loading. Please reload this page.
doc: document major finished changes in v14 - #33065
Closed
ronag wants to merge 5 commits into
Closed
Conversation
ronagforce-pushed
the
finished-changes-history
branch
6 times, most recently
from
April 25, 2020 19:25
ba4897e to
329583bCompareAdded description of semver-major changes to finished in v14.
ronagforce-pushed
the
finished-changes-history
branch
from
April 25, 2020 19:26
329583b to
9392877Comparejasnell
approved these changes
Apr 25, 2020
MemberAuthor
@nodejs/documentation https://github.com/nodejs/node/pull/33065/checks?check_run_id=618533325 |
lpinca
approved these changes
Apr 26, 2020
juanarbol
approved these changes
Apr 26, 2020
nodejs-github-bot
commented
Apr 26, 2020
Collaborator
trivikr
approved these changes
Apr 26, 2020
MemberAuthor
Stuck at formatting issue. |
addaleax
commented
Apr 26, 2020
Member
addaleax
approved these changes
Apr 26, 2020
addaleax
left a comment
Member
There was a problem hiding this comment.
LGTM with the linter/doc build passing
nodejs-github-bot
commented
Apr 27, 2020
Collaborator
nodejs-github-bot
commented
Apr 27, 2020
Collaborator
ronag
commented
Apr 27, 2020
MemberAuthor
Still formatting issues 😕 |
addaleax
commented
Apr 27, 2020
Member
@ronag Ah yeah, YAML is not a fan of strings starting with backticks … you can make the first line |
nodejs-github-bot
commented
Apr 27, 2020
Collaborator
aduh95
reviewed
Apr 27, 2020
Uh oh!
There was an error while loading. Please reload this page.
ronag
commented
Apr 27, 2020
MemberAuthor
Landed in e5512ac |
ronag added a commit
that referenced
this pull request
Apr 27, 2020
Added description of semver-major changes to finished in v14. PR-URL: #33065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
Added description of semver-major changes to finished in v14. PR-URL: #33065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
Added description of semver-major changes to finished in v14. PR-URL: #33065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit
that referenced
this pull request
Apr 28, 2020
Added description of semver-major changes to finished in v14. PR-URL: #33065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2020
Added description of semver-major changes to finished in v14. PR-URL: #33065 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added description of semver-major changes to finished in v14.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes