Skip to content

doc: add util.types.isArrayBufferView() - #33092

Closed
kevinoid wants to merge 1 commit into
nodejs:masterfrom
kevinoid:doc-isArrayBufferView
Closed

doc: add util.types.isArrayBufferView()#33092
kevinoid wants to merge 1 commit into
nodejs:masterfrom
kevinoid:doc-isArrayBufferView

Conversation

@kevinoid

Copy link
Copy Markdown
Contributor

This function was added by #15663, but was never documented. This PR adds it to the documentation for util.

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Apr 27, 2020
This function was added by nodejs#15663, but was never documented.
This commit documents it.
@kevinoid
kevinoidforce-pushed the doc-isArrayBufferView branch from aec04a8 to cb8f51eCompareApril 27, 2020 13:18

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@rexagodrexagod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2020
gireeshpunathil pushed a commit that referenced this pull request May 2, 2020
This function was added by #15663,
but was never documented. This commit documents it.
PR-URL: #33092
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@gireeshpunathil

Copy link
Copy Markdown
Member

landed in 7c36ec3

@kevinoid

Copy link
Copy Markdown
ContributorAuthor

Hurrah! Thanks everyone for taking the time to review and merge it.

targos pushed a commit that referenced this pull request May 4, 2020
This function was added by #15663,
but was never documented. This commit documents it.
PR-URL: #33092
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@targostargos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
This function was added by #15663,
but was never documented. This commit documents it.
PR-URL: #33092
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
@targostargos mentioned this pull request May 7, 2020
targos pushed a commit that referenced this pull request May 13, 2020
This function was added by #15663,
but was never documented. This commit documents it.
PR-URL: #33092
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@kevinoid@gireeshpunathil@jasnell@lpinca@shisama@juanarbol@rexagod@puzpuzpuz@addaleax@nodejs-github-bot