http: don't throw on `Uint8Array`s for `http.ServerResponse#write` by rexagod · Pull Request #33155 · nodejs/node

rexagod · 2020-04-30T04:43:23Z

Same as #33146 but for write

Refs: #29829
Fixes: #33379

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

ronag

I would prefer if you tried to make it as similar as possible to what's in Writable.

Also, please try to avoid unrelated whitespace changes.

addaleax · 2020-05-02T21:51:09Z

Yeah, I think this should also change the HTTP/1 code and leave HTTP/2 alone because that’s already doing the right thing, like #33146 👍

rexagod · 2020-05-02T22:55:20Z

@addaleax Sorry but I'm confused as to what you are referring to the 'right thing'. If I'm understanding this right, do you want me to remove these type checks for write (in http2), and what should I change in http/1 (since it already has type checks)?

addaleax · 2020-05-02T23:15:28Z

@rexagod Fit the HTTP/1 code so that it also accepts any type of Uint8Array (i.e. replace chunk instanceof Buffer with isUint8Array and fix up the error message, just like #33146), and don’t modify the HTTP/2 code because that passes the chunk along to Writable.prototype.write, which already performs correct typechecking (= chunk is string or Uint8Array).

rexagod · 2020-05-03T06:20:33Z

Thank you so much for clearing this up for me, @addaleax! Sometimes I miss to see the obvious and it's really frustrating! 😅

BridgeAR · 2020-05-03T17:18:32Z

@ronag PTAL. I think your comment got resolved.

ronag

This is changing http1 which already has type checks. Not sure if the Uint8Array check works so that might be worth fixing.

rexagod · 2020-05-10T09:16:12Z

@ronag Should I remove all changes from outgoing and just commit the test?

ronag · 2020-05-10T09:23:58Z

@ronag Should I remove all changes from outgoing and just commit the test?

Could you also add a test for the uint8array case? Also please fix the commit msg and PR description.

dont throw errors on Uint8Arrays and added test for all valid types Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de> fixup: remove dup fixup: remove unused dec fixup: add Uint8Array check in test fixup: don't throw invalid arg error on `Uint8Array`s

nodejs-github-bot · 2020-05-10T17:29:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31265/

targos · 2020-05-16T08:51:11Z

Landed in 2b50cd7

Don't throw errors on Uint8Arrays and added test for all valid types. PR-URL: #33155Fixes: #33379 Refs: #29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2020-05-16T19:56:01Z

@rexagod should this go back to v14.x? It changes something introduced in #31818, which is semver-major.

addaleax · 2020-05-17T03:42:07Z

@codebytere Yes, it just needs to be applied in a different part of the function that #31818 had moved around (but not really introduced).

@rexagod Would you be willing to backport this yourself? The guide for how to do that is in https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md. If you’d prefer, you can also let us know that somebody else should pick that up.

Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: nodejs#33488 PR-URL: nodejs#33155Fixes: nodejs#33379 Refs: nodejs#29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: nodejs#33490 PR-URL: nodejs#33155Fixes: nodejs#33379 Refs: nodejs#29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

rexagod · 2020-05-20T23:44:20Z

ping @addaleax

Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: #33490 PR-URL: #33155Fixes: #33379 Refs: #29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: #33488 PR-URL: #33155Fixes: #33379 Refs: #29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jimmywarting · 2020-09-15T13:44:43Z

The title says http.ServerResponse#write
but how about http.ClientRequest? can you write uint8 to request also? currently don't work in node v12

Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: nodejs/node#33488 PR-URL: nodejs/node#33155Fixes: nodejs/node#33379 Refs: nodejs/node#29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. labels Apr 30, 2020

rexagod force-pushed the i-29829-15 branch 3 times, most recently from 4cf2098 to 7ce222fCompare April 30, 2020 04:56

ronag requested changes Apr 30, 2020
View reviewed changes

rexagod changed the title ~~http2: add checks for Http2Server.Response.write~~http2: add type checks for Http2Server.Response.writeMay 1, 2020

rexagod force-pushed the i-29829-15 branch 2 times, most recently from 56a56f0 to b253d17Compare May 3, 2020 06:08

addaleax approved these changes May 3, 2020
View reviewed changes

Comment threadlib/_http_outgoing.js Outdated
Comment threadtest/parallel/test-http-outgoing-write-types.js Outdated

BridgeAR reviewed May 3, 2020
View reviewed changes

Comment threadtest/parallel/test-http-outgoing-write-types.js Outdated
Comment threadtest/parallel/test-http-outgoing-write-types.js Outdated

rexagod force-pushed the i-29829-15 branch 2 times, most recently from 83686ad to fde814eCompare May 10, 2020 08:38

ronag reviewed May 10, 2020
View reviewed changes

Comment threadlib/_http_outgoing.js Outdated

ronag requested changes May 10, 2020
View reviewed changes

rexagod force-pushed the i-29829-15 branch 2 times, most recently from 3872384 to 33484b2Compare May 10, 2020 16:57

rexagod force-pushed the i-29829-15 branch from 33484b2 to 6a4d9b2Compare May 10, 2020 17:01

fixup: lint
cf914d5

ronag changed the title ~~http2: add type checks for Http2Server.Response.write~~http: don't throw on Uint8Arrays for http.ServerResponse#writeMay 10, 2020

ronag approved these changes May 10, 2020
View reviewed changes

jasnell approved these changes May 15, 2020
View reviewed changes

targos closed this May 16, 2020

addaleax added backport-requested-v12.x labels May 17, 2020

rexagod mentioned this pull request May 20, 2020
[v12.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write#33488
Closed
4 tasks

rexagod mentioned this pull request May 20, 2020
[v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write#33490
Closed
4 tasks

targos added backport-open-v12.x and removed backport-requested-v12.x labels May 25, 2020

rexagod mentioned this pull request Jun 6, 2020
The differences between http2 compatibility API and http[s] #29829
Closed
32 tasks

codebytere mentioned this pull request Jun 28, 2020
v14.5.0 proposal #34093
Merged

codebytere mentioned this pull request Sep 28, 2020
v12.19.0 proposal #35401
Merged

targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 25, 2021

Flarna mentioned this pull request Oct 26, 2022
doc, http: add Uint8Array as allowed type #45167
Merged

Uh oh!

Uh oh!

Conversation

rexagod commented Apr 30, 2020• edited by addaleax Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ronag left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented May 2, 2020

Uh oh!

rexagod commented May 2, 2020

Uh oh!

addaleax commented May 2, 2020

Uh oh!

rexagod commented May 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BridgeAR commented May 3, 2020

Uh oh!

Uh oh!

ronag left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rexagod commented May 10, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronag commented May 10, 2020

Uh oh!

nodejs-github-bot commented May 10, 2020

Uh oh!

targos commented May 16, 2020

Uh oh!

codebytere commented May 16, 2020

Uh oh!

addaleax commented May 17, 2020

Uh oh!

rexagod commented May 20, 2020

Uh oh!

jimmywarting commented Sep 15, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

rexagod commented Apr 30, 2020•
edited by addaleax
Loading

ronag left a comment •
edited
Loading

rexagod commented May 10, 2020•
edited
Loading

jimmywarting commented Sep 15, 2020•
edited
Loading