Skip to content

build: run full test suite in ASAN action - #33170

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:reenable-asan
Closed

build: run full test suite in ASAN action#33170
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:reenable-asan

Conversation

@addaleax

@addaleaxaddaleax commented Apr 30, 2020

Copy link
Copy Markdown
Member

Refs: #32776

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
addaleax requested a review from mmarchiniApril 30, 2020 17:22
@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 30, 2020
@addaleax

addaleax commented Apr 30, 2020

Copy link
Copy Markdown
MemberAuthor

Looks like there’s a few (real) issues that make test-fs-opendir flaky here.

@addaleaxaddaleax added the blocked PRs that are blocked by other issues or PRs. label May 6, 2020
@addaleax

addaleax commented May 7, 2020

Copy link
Copy Markdown
MemberAuthor

Blocked on #33274 and libuv/libuv#2837

@addaleaxaddaleax added the review wanted PRs that need reviews. label May 7, 2020
@addaleaxaddaleax added build Issues and PRs related to build files or the CI. and removed blocked PRs that are blocked by other issues or PRs. meta Issues and PRs related to the general management of the project. labels May 19, 2020
@addaleax

addaleax commented May 19, 2020

Copy link
Copy Markdown
MemberAuthor

@nodejs/build-files @mmarchini@gengjiawen I’ve rebased this, PTAL

mmarchini
mmarchini approved these changes May 19, 2020
View reviewed changes

@mmarchinimmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@addaleax

addaleax commented May 19, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 7c755b0 🎉

addaleax added a commit that referenced this pull request May 19, 2020
@addaleax
build: run full test suite in ASAN action
7c755b0
Refs: #32776
PR-URL: #33170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@addaleax
addaleax deleted the reenable-asan branch May 19, 2020 21:34
@gengjiawen

gengjiawen commented May 20, 2020

Copy link
Copy Markdown
Member

Great work.

codebytere pushed a commit that referenced this pull request May 21, 2020
@addaleax@codebytere
build: run full test suite in ASAN action
02e8c14
Refs: #32776
PR-URL: #33170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
QwireyInc pushed a commit to QwireyInc/node that referenced this pull request Apr 19, 2025
@addaleax@targos
build: run full test suite in ASAN action
85ce30f
Refs: nodejs/node#32776
PR-URL: nodejs/node#33170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.review wantedPRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@gengjiawen@cjihrig@mmarchini@codebytere@nodejs-github-bot